From: Cyrill Gorcunov <gorcunov@gmail.com> To: Konstantin Osipov <kostja@tarantool.org> Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com Subject: Re: [tarantool-patches] [rfc 3/4] core/fiber: Put static watermark into stack to track its usage Date: Tue, 5 Mar 2019 11:27:11 +0300 [thread overview] Message-ID: <20190305082711.GL13301@uranus.lan> (raw) In-Reply-To: <20190305082029.GL21955@chai> On Tue, Mar 05, 2019 at 11:20:29AM +0300, Konstantin Osipov wrote: > > As a policy we write meaningful comments for every function, static or not, > obvious or not. The idea of such a comment is to reflect the > author's intent and technical trade-offs considered when designing > a function. The comment should preferably be concise, however. > > > +/* > > + * Random values generated with uuid. > > + * Try to fit a cache line. > > I don't understand this comment. Since you're putting a poison-gap > between each number, how could you possibly fit a cache line? size of the poison_pool itself, we actively access this array, so better keep it small enough > > + */ > > +static const uint64_t poison_pool[] = { > > + 0x74f31d37285c4c37, 0xb10269a05bf10c29, > > + 0x0994d845bd284e0f, 0x9ffd4f7129c184df, > > + 0x357151e6711c4415, 0x8c5e5f41aafe6f28, > > + 0x6917dd79e78049d5, 0xba61957c65ca2465, > > +}; > > + > > +/* > > + * We poison by 8 bytes as it natural for stack > > + * step on x86-64. Also 128 byte gap between > > + * poison values should cover a common cases. > > > + /** Stack watermark addr for overflow detection. */ > > + void *stack_wmark_ofl; > > Generally we try to avoid abbreviations unless really necessary. > Why not simply stack_overflow_watermark? Well, as to me it is too long, but sure, will update. Cyrill
next prev parent reply other threads:[~2019-03-05 8:27 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-02 12:55 [rfc 0/4] fiber/stack: Increase stack size and shrink rss usage Cyrill Gorcunov 2019-03-02 12:55 ` [rfc 1/4] core/fiber: Increase default stack size Cyrill Gorcunov 2019-03-02 12:55 ` [rfc 2/4] core/fiber: Mark stack as unneeded on creation Cyrill Gorcunov 2019-03-02 12:55 ` [rfc 3/4] core/fiber: Put static watermark into stack to track its usage Cyrill Gorcunov 2019-03-05 8:08 ` [tarantool-patches] " Konstantin Osipov 2019-03-05 8:17 ` Cyrill Gorcunov 2019-03-05 8:10 ` Konstantin Osipov 2019-03-05 8:14 ` Cyrill Gorcunov 2019-03-05 19:17 ` Cyrill Gorcunov 2019-03-05 8:20 ` Konstantin Osipov 2019-03-05 8:27 ` Cyrill Gorcunov [this message] 2019-03-02 12:55 ` [rfc 4/4] core/fiber: Shrink stack when recycling Cyrill Gorcunov 2019-03-05 8:30 ` [tarantool-patches] " Konstantin Osipov 2019-03-05 8:41 ` Cyrill Gorcunov 2019-03-05 9:32 ` [tarantool-patches] " Konstantin Osipov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190305082711.GL13301@uranus.lan \ --to=gorcunov@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [tarantool-patches] [rfc 3/4] core/fiber: Put static watermark into stack to track its usage' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox