Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool <tarantool-patches@freelists.org>
Subject: Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded directories
Date: Mon, 4 Mar 2019 13:32:34 +0300	[thread overview]
Message-ID: <20190304103234.GH13301@uranus.lan> (raw)
In-Reply-To: <20190304101536.ch5uanhwt2z7uol4@esperanza>

On Mon, Mar 04, 2019 at 01:15:36PM +0300, Vladimir Davydov wrote:
> > > 
> > > > +list(APPEND tagsExclude "--exclude=.pc/*")
> > > 
> > > What's in '.pc'?
> > 
> > quilt uses it to stack data.
> 
> AFAIK ctags will simply ignore those. It doesn't tag anything in .git
> either. Come to think of it, do we really need to explicitly exclude
> those dirs?

yes we should, simply because it is pointless to force ctags to scan
directory where we _know_ no useful data present, so it will process
a bit faster.

as to .pc -- quilt pushes there original .c|.h when a patch applied,
so this generates unrelated tags and should be excluded from scanning.

> > Guys, maybe we should simply tag src/ directory only? Or there someone
> > who is using tags for tests, third party and etc?
> 
> Tagging third_party is useful. We even patch those sometimes.
> I'm not sure why it's not in src/ though.
> 
> Tagging tests is mostly useless, you're correct, but it doesn't hurt
> much.

until one day :) but I don't insist

> There's also a bunch of autogenerated files (e.g. *.lua.c and module.h).
> I wonder if it makes sense to tag those. I guess it does.

I think the same

	Cyrill

  reply	other threads:[~2019-03-04 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-02 14:44 [tarantool-patches] [PATCH] " Cyrill Gorcunov
2019-03-02 15:10 ` [tarantool-patches] " Cyrill Gorcunov
2019-03-02 15:40   ` [tarantool-patches] [PATCH v2] " Cyrill Gorcunov
2019-03-04  9:57     ` Vladimir Davydov
2019-03-04 10:09       ` Cyrill Gorcunov
2019-03-04 10:15         ` Vladimir Davydov
2019-03-04 10:32           ` Cyrill Gorcunov [this message]
2019-03-04 15:44     ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190304103234.GH13301@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded directories' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox