From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool <tarantool-patches@freelists.org>
Subject: Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded directories
Date: Mon, 4 Mar 2019 12:57:34 +0300 [thread overview]
Message-ID: <20190304095734.cfuhxdzw6cajpm6x@esperanza> (raw)
In-Reply-To: <20190302154012.GE13301@uranus.lan>
On Sat, Mar 02, 2019 at 06:40:12PM +0300, Cyrill Gorcunov wrote:
> When building "tags" target we scan the whole working
> directory which is redundant. In particular .git,.pc,patches
> directories should not be scanned for sure.
> ---
> v2:
> - fix typos
>
> CMakeLists.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Index: tarantool.git/CMakeLists.txt
> ===================================================================
> --- tarantool.git.orig/CMakeLists.txt
> +++ tarantool.git/CMakeLists.txt
> @@ -137,7 +137,10 @@ check_function_exists(getprogname HAVE_G
> #
> # Enable 'make tags' target.
> #
> -add_custom_target(tags COMMAND ${CTAGS} -R -f tags
> +list(APPEND tagsExclude "--exclude=.git/*")
Great!
> +list(APPEND tagsExclude "--exclude=.pc/*")
What's in '.pc'?
> +list(APPEND tagsExclude "--exclude=patches/*")
> +add_custom_target(tags COMMAND ${CTAGS} -R ${tagsExclude} -f tags
> WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
> add_custom_target(ctags DEPENDS tags)
>
>
next prev parent reply other threads:[~2019-03-04 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 14:44 [tarantool-patches] [PATCH] " Cyrill Gorcunov
2019-03-02 15:10 ` [tarantool-patches] " Cyrill Gorcunov
2019-03-02 15:40 ` [tarantool-patches] [PATCH v2] " Cyrill Gorcunov
2019-03-04 9:57 ` Vladimir Davydov [this message]
2019-03-04 10:09 ` Cyrill Gorcunov
2019-03-04 10:15 ` Vladimir Davydov
2019-03-04 10:32 ` Cyrill Gorcunov
2019-03-04 15:44 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304095734.cfuhxdzw6cajpm6x@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v2] build: tags -- Exclude unneeded directories' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox