From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: tarantool-patches@freelists.org
Subject: Re: [PATCH] test: fix app/socket sporadic failure
Date: Thu, 28 Feb 2019 18:31:53 +0300 [thread overview]
Message-ID: <20190228153153.6aplzpm57trcr5bh@esperanza> (raw)
In-Reply-To: <216e0b14c8981ddbd110d2b4d9562194acdc7860.1551366539.git.vdavydov.dev@gmail.com>
On Thu, Feb 28, 2019 at 06:09:41PM +0300, Vladimir Davydov wrote:
> The patch fixes the following test failure:
>
> | --- app/socket.result Mon Feb 25 17:32:49 2019
> | +++ app/socket.reject Mon Feb 25 17:39:51 2019
> | @@ -2827,7 +2827,7 @@
> | ...
> | echo_fiber ~= nil
> | ---
> | -- true
> | +- false
> | ...
> | client:write('hello')
> | ---
>
> This happens, because we don't wait for echo_fiber to start.
> Use a channel to make sure it does. Also, increase read/write
> timeouts from 0.1 up to 5 seconds - it won't increase the test
> runtime, but it will make it more robust.
>
> Closes #4022
> ---
> https://github.com/tarantool/tarantool/issues/4022
> https://github.com/tarantool/tarantool/commits/dv/test-fixes
>
> test/app/socket.result | 12 +++++++++---
> test/app/socket.test.lua | 9 ++++++---
> 2 files changed, 15 insertions(+), 6 deletions(-)
Pushed to 2.1 and 1.10.
prev parent reply other threads:[~2019-02-28 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:09 Vladimir Davydov
2019-02-28 15:31 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228153153.6aplzpm57trcr5bh@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] test: fix app/socket sporadic failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox