Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@freelists.org, georgy@tarantool.org,
	i.kosarev@corp.mail.ru
Subject: Re: [PATCH v7] iproto: report active connections number
Date: Thu, 28 Feb 2019 18:31:11 +0300	[thread overview]
Message-ID: <20190228153111.swyqc3grur2fwgdt@esperanza> (raw)
In-Reply-To: <20190228141627.19799-1-i.kosarev@tarantool.org>

On Thu, Feb 28, 2019 at 05:16:27PM +0300, Ilya Kosarev wrote:
> Now there is new member in box.stat.net() called "CONNECTIONS"
> which is a number of active iproto connections.
> 
> Closes #3905
> 
> @TarantoolBot document
> Title: box.stat.net
> Update the documentation for box.stat.net
> to reflect the addition of the field
> which reports iproto connections number.
> ---
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3905-report-connections-number
> https://github.com/tarantool/tarantool/issues/3905
> 
> Changes in v7:
> - reduced line length in commit message

Please in future retain full change log, like this:

Changes in v7:
 - reduced line length in commit message
Changes in v6:
 - added docbot request to commit message
Changes in v5:
 - review-based polishing
Changes in v4:
 - CONNECTIONS counter doesn't have extra lua tables inside anymore
 - refactoring
...

It's nice to see how the patch evolved.

> 
>  src/box/iproto.cc          |  6 ++++++
>  src/box/iproto.h           |  6 ++++++
>  src/box/lua/stat.c         |  9 +++++++++
>  test/box/stat_net.result   | 37 +++++++++++++++++++++++++++++++++++++
>  test/box/stat_net.test.lua | 13 +++++++++++++
>  5 files changed, 71 insertions(+)
> 

Pushed to 2.1 and 1.10. Thanks!

      reply	other threads:[~2019-02-28 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 14:16 Ilya Kosarev
2019-02-28 15:31 ` Vladimir Davydov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228153111.swyqc3grur2fwgdt@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=georgy@tarantool.org \
    --cc=i.kosarev@corp.mail.ru \
    --cc=i.kosarev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v7] iproto: report active connections number' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox