Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergei Voronezhskii <sergw@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [PATCH] Disable bad url http client test only for OSX
Date: Thu, 28 Feb 2019 11:13:02 +0300	[thread overview]
Message-ID: <20190228081302.17329-1-sergw@tarantool.org> (raw)

Fixes #3564
---
BRANCH: https://github.com/tarantool/tarantool/tree/sergw/fix-osx-http-client-test
BUILD: https://travis-ci.org/tarantool/tarantool/builds/498215296
 test/app-tap/http_client.test.lua | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/test/app-tap/http_client.test.lua b/test/app-tap/http_client.test.lua
index 5493dd4ff..8cf790a6e 100755
--- a/test/app-tap/http_client.test.lua
+++ b/test/app-tap/http_client.test.lua
@@ -74,7 +74,7 @@ local function test_http_client(test, url, opts)
     test:ok(r.body:match("hello") ~= nil, "body")
     test:ok(tonumber(r.headers["content-length"]) > 0,
         "content-length > 0")
-    test:is(client.get("http://localhost:1/").status, 595, 'cannot connect')
+    if jit.os == "OSX" then test:skip('osx skip') else test:is(client.get("http://localhost:1/").status, 595, 'cannot connect') end
 
     local r = client.request('GET', url, nil, opts)
     test:is(r.status, 200, 'request')
@@ -204,8 +204,12 @@ local function test_errors(test)
     test:ok(not status and string.find(json.encode(err),
                         "Unsupported protocol"),
                         "POST: exception on bad protocol")
-    local r = http:get("http://do_not_exist_8ffad33e0cb01e6a01a03d00089e71e5b2b7e9930dfcba.ru")
-    test:is(r.status, 595, "GET: response on bad url")
+    if jit.os == "OSX" then
+        test:skip('osx skip')
+    else
+        local r = http:get("http://do_not_exist_8ffad33e0cb01e6a01a03d00089e71e5b2b7e9930dfcba.ru")
+        test:is(r.status, 595, "GET: response on bad url")
+    end
 end
 
 local function test_headers(test, url, opts)
-- 
2.18.0

             reply	other threads:[~2019-02-28  8:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28  8:13 Sergei Voronezhskii [this message]
2019-03-05 16:58 ` [tarantool-patches] " Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228081302.17329-1-sergw@tarantool.org \
    --to=sergw@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [PATCH] Disable bad url http client test only for OSX' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox