From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: "Георгий Кириченко" <georgy@tarantool.org>,
tarantool-patches@freelists.org
Subject: Re: [RFC v3] fiber: Increase default stack size
Date: Tue, 26 Feb 2019 15:54:57 +0300 [thread overview]
Message-ID: <20190226125457.GP7198@uranus> (raw)
In-Reply-To: <20190226123456.k66j25qv57vygm6u@esperanza>
On Tue, Feb 26, 2019 at 03:34:56PM +0300, Vladimir Davydov wrote:
> >
> > If we want to scatter we should simply put marks at page bounds.
> > Dirtifying somewhere inside middle of a page is useless.
>
> Hmm, why? Consider the example with PATH_MAX buffer. Putting dirty marks
> at page boundaries doesn't guarantee any of them will get overwritten by
> the buffer if only a few hundred of bytes are used. I think we should
> dirty the last page or two at random intervals - this should increase
> the chance that at least one mark is overwritten by any function that is
> eager for the stack.
Ah, I got what you mean. Look, maybe we should consider pagemap too?
iirc readin pagemap should be cheap but need to read the code though,
will try once time permit.
next prev parent reply other threads:[~2019-02-26 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:16 [tarantool-patches] [RFC v2] " Cyrill Gorcunov
2019-02-25 14:55 ` Vladimir Davydov
2019-02-25 15:25 ` Cyrill Gorcunov
2019-02-25 21:39 ` [RFC v3] " Cyrill Gorcunov
2019-02-26 8:58 ` Vladimir Davydov
2019-02-26 9:12 ` Cyrill Gorcunov
2019-02-26 10:26 ` Vladimir Davydov
2019-02-26 10:36 ` Vladimir Davydov
2019-02-26 11:17 ` Cyrill Gorcunov
2019-02-26 12:25 ` Vladimir Davydov
2019-02-26 11:16 ` Cyrill Gorcunov
2019-02-26 12:34 ` Vladimir Davydov
2019-02-26 12:54 ` Cyrill Gorcunov [this message]
2019-02-26 13:06 ` Vladimir Davydov
2019-02-26 13:26 ` [tarantool-patches] " Konstantin Osipov
2019-02-26 14:02 ` Cyrill Gorcunov
2019-02-26 10:32 ` Vladimir Davydov
2019-02-26 11:18 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226125457.GP7198@uranus \
--to=gorcunov@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [RFC v3] fiber: Increase default stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox