From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: "Георгий Кириченко" <georgy@tarantool.org>,
tarantool-patches@freelists.org
Subject: Re: [RFC v3] fiber: Increase default stack size
Date: Tue, 26 Feb 2019 14:17:23 +0300 [thread overview]
Message-ID: <20190226111723.GN7198@uranus> (raw)
In-Reply-To: <20190226103659.oofo2bcnuztu44eg@esperanza>
On Tue, Feb 26, 2019 at 01:36:59PM +0300, Vladimir Davydov wrote:
> On Tue, Feb 26, 2019 at 01:26:56PM +0300, Vladimir Davydov wrote:
> > - 1 MB for max stack size seems to be a bit of an overkill for now.
> > The default value should be set to 256 KB, but we do need a
> > configuration option for it. Let's add it to the fiber Lua module.
> > May be done in a separate patch, but should be submitted together in
> > the same patch set.
>
> Almost forgot. We should also print a warning to the log if some fiber
> has gone too close to the stack limit (say half of the max allocation)
> to indicate that the max stack size should be increased.
Do we have something similar to printf_ratelimited() so we wouldn't
spam a user too much?
next prev parent reply other threads:[~2019-02-26 11:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:16 [tarantool-patches] [RFC v2] " Cyrill Gorcunov
2019-02-25 14:55 ` Vladimir Davydov
2019-02-25 15:25 ` Cyrill Gorcunov
2019-02-25 21:39 ` [RFC v3] " Cyrill Gorcunov
2019-02-26 8:58 ` Vladimir Davydov
2019-02-26 9:12 ` Cyrill Gorcunov
2019-02-26 10:26 ` Vladimir Davydov
2019-02-26 10:36 ` Vladimir Davydov
2019-02-26 11:17 ` Cyrill Gorcunov [this message]
2019-02-26 12:25 ` Vladimir Davydov
2019-02-26 11:16 ` Cyrill Gorcunov
2019-02-26 12:34 ` Vladimir Davydov
2019-02-26 12:54 ` Cyrill Gorcunov
2019-02-26 13:06 ` Vladimir Davydov
2019-02-26 13:26 ` [tarantool-patches] " Konstantin Osipov
2019-02-26 14:02 ` Cyrill Gorcunov
2019-02-26 10:32 ` Vladimir Davydov
2019-02-26 11:18 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226111723.GN7198@uranus \
--to=gorcunov@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [RFC v3] fiber: Increase default stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox