Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org, vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] Re: [PATCH 2/2] Move 'core' and 'uuid' libs to src/lib
Date: Tue, 26 Feb 2019 13:27:37 +0300	[thread overview]
Message-ID: <20190226102737.GA5592@chai> (raw)
In-Reply-To: <2f04d991-10c2-ba20-9624-8ae2cf425069@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/26 12:41]:
> On 26/02/2019 11:30, Konstantin Osipov wrote:
> > * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/26 00:59]:
> > > For the same reason why 'uri' was moved to src/lib - SWIM needs
> > > core and uuid, and SWIM will live in src/lib.
> > > 
> > > This commit follows 'uri' relocation as a separate one because
> > > 'uri' relocation required some changes in the files, moved by
> > > this commit.
> > 
> > The patch itself is looking good to me, it's a pity collation
> > library depends on the core, I would perhaps make it separate if
> > possible, but we're doing swim after all, right?
> > 
> > The same applies to http parser.
> 
> Citing your own words - you said, that we do not need to split
> libraries now. For SWIM it is enough to just move existing uri
> and core libraries into src/lib, without any changes inside the
> latter.
> 
> But if you want to extract collation and http, I can do that.
> Should I?

Up to you. If you find it easy to do (within 1 hour of your time
for each patch) - please don't postpone it.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-02-26 10:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 20:56 [PATCH 0/2] Move 'core' lib " Vladislav Shpilevoy
2019-02-25 20:56 ` [PATCH 1/2] Move 'uri' lib to src/lib/ Vladislav Shpilevoy
2019-02-26  8:27   ` [tarantool-patches] " Konstantin Osipov
2019-02-26 12:07     ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-25 20:56 ` [PATCH 2/2] Move 'core' and 'uuid' libs to src/lib Vladislav Shpilevoy
2019-02-26  8:30   ` [tarantool-patches] " Konstantin Osipov
2019-02-26  9:38     ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-26 10:27       ` Konstantin Osipov [this message]
2019-02-26 12:11         ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190226102737.GA5592@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH 2/2] Move '\''core'\'' and '\''uuid'\'' libs to src/lib' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox