From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 3/5] sql: save SQL parser errors in diag_set()
Date: Tue, 26 Feb 2019 11:25:49 +0300 [thread overview]
Message-ID: <20190226082549.GB2696@chai> (raw)
In-Reply-To: <A2C6F7A3-E038-4F59-B599-2BC6BF9524E5@tarantool.org>
* n.pettik <korablev@tarantool.org> [19/02/26 10:06]:
> > + /*186 */_(ER_SQL_PARSER_GENERIC, "%s") \
>
> Hmm, what is this?
This is a catch-all for all the errors we don't have time to
classify and prettify now. I suggested the same approach for all
the remaining sqlite errors: add a few catch-all tarantool error
codes which we will refine and deprecate after box.sql.execute()
removal is in.
Let's not forget the original patch that triggered this
refactoring, I want to push it asap as well.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-26 8:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 17:14 [tarantool-patches] [PATCH v2 0/5] sql: use diag_set() for errors in SQL imeevma
2019-02-25 17:14 ` [tarantool-patches] [PATCH v2 1/5] sql: remove "syntax error after column name" error imeevma
2019-02-25 19:34 ` [tarantool-patches] " n.pettik
2019-02-27 11:32 ` Kirill Yukhin
2019-02-25 17:14 ` [tarantool-patches] [PATCH v2 2/5] sql: rework syntax errors imeevma
2019-02-25 20:02 ` [tarantool-patches] " n.pettik
2019-02-26 8:24 ` Konstantin Osipov
2019-02-26 12:59 ` n.pettik
2019-02-26 13:12 ` Konstantin Osipov
2019-02-26 15:59 ` Imeev Mergen
2019-02-25 17:14 ` [tarantool-patches] [PATCH v2 3/5] sql: save SQL parser errors in diag_set() imeevma
2019-02-25 23:01 ` [tarantool-patches] " n.pettik
2019-02-26 8:25 ` Konstantin Osipov [this message]
2019-02-26 15:29 ` Imeev Mergen
2019-02-25 17:14 ` [tarantool-patches] [PATCH v2 4/5] sql: remove file zErrMsg of struct Parse imeevma
2019-02-26 14:47 ` [tarantool-patches] " n.pettik
2019-02-26 15:36 ` Imeev Mergen
2019-02-26 18:17 ` n.pettik
2019-02-25 17:14 ` [tarantool-patches] [PATCH v2 5/5] sql: remove field nErr " imeevma
2019-02-26 8:27 ` [tarantool-patches] " Konstantin Osipov
2019-02-26 14:48 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226082549.GB2696@chai \
--to=kostja@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 3/5] sql: save SQL parser errors in diag_set()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox