Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja.osipov@gmail.com>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v3 1/7] memtx: introduce universal iterator_pool
Date: Mon, 25 Feb 2019 19:46:58 +0300	[thread overview]
Message-ID: <20190225164658.GE2663@chai> (raw)
In-Reply-To: <20190224182251.d65st3ncjheabeuf@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/24 21:24]:
> On Sun, Feb 24, 2019 at 08:15:04PM +0300, Konstantin Osipov wrote:
> > * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/24 10:01]:
> > > On Fri, Feb 22, 2019 at 09:37:25PM +0300, Konstantin Osipov wrote:
> > > > * Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/02/22 19:29]:
> > > > > Memtx uses separate mempools for iterators of different types.
> > > > > Due to the fact that there will be more iterators of different
> > > > > sizes in a series of upcoming changes, let's always allocate the
> > > > > iterator of the largest size.
> > > > 
> > > > If rtree iterator is the one which is largest, let's use a
> > > > separate pool for it. 
> > > > 
> > > > In general mempools are rather cheap. Each mempool takes a slab
> > > > for ~100 objects and uses no slabs if there are no objects (e.g.
> > > > if rtree index is not used, there is no mempool memory for it).
> > > 
> > > But I'd rather prefer to use the same mempool for all kinds of iterator
> > > objects to simplify the code. Take a look at how those mempools are
> > > initialized on demand. IMO it looks ugly. Do we really want to save
> > > those 500 of bytes that much to put up with that complexity?

I don't know much, but a typical SAP R3 which I working on making 
work well with one open source database back in 2003 had ~100k
open client cursors. This could easily entail hundreds of
thousands of server side iterators.

> Regarding the bps tree performance issue. I see nothing wrong about it.
> We've found an issue and we'll surely fix it. There was no point to
> think about such a minor optimization until we actually faced the
> problem. My point is we should strive to write simple and reliable code
> first, and optimize it only if there's a demand, otherwise we risk
> turning the code into unmaintainable mess for no good reason.

I agree with your point, I just disagree that this optimization is
not practical.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-02-25 16:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 15:42 [PATCH v3 0/7] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-02-22 15:42 ` [PATCH v3 1/7] memtx: introduce universal iterator_pool Kirill Shcherbatov
2019-02-22 18:37   ` [tarantool-patches] " Konstantin Osipov
2019-02-23 12:03     ` Kirill Shcherbatov
2019-02-25 16:14       ` Vladimir Davydov
2019-02-25 16:39         ` [tarantool-patches] " Kirill Shcherbatov
2019-02-25 17:14           ` Vladimir Davydov
2019-02-24  6:56     ` [tarantool-patches] " Vladimir Davydov
2019-02-24 17:15       ` Konstantin Osipov
2019-02-24 18:22         ` Vladimir Davydov
2019-02-25 16:46           ` Konstantin Osipov [this message]
2019-02-25 17:15             ` [tarantool-patches] " Vladimir Davydov
2019-02-22 15:42 ` [PATCH v3 2/7] lib: fix undef _api_name in bps_tree header Kirill Shcherbatov
2019-02-22 18:37   ` [tarantool-patches] " Konstantin Osipov
2019-02-25 15:32   ` Vladimir Davydov
2019-02-22 15:42 ` [PATCH v3 3/7] lib: introduce BPS_TREE_IDENTICAL custom comparator Kirill Shcherbatov
2019-02-25 15:33   ` Vladimir Davydov
2019-02-22 15:42 ` [PATCH v3 4/7] memtx: hide index implementation details from header Kirill Shcherbatov
2019-02-22 18:40   ` [tarantool-patches] " Konstantin Osipov
2019-02-25 15:33   ` Vladimir Davydov
2019-02-22 15:42 ` [PATCH v3 5/7] memtx: rework memtx_tree to store arbitrary nodes Kirill Shcherbatov
2019-02-25 16:57   ` Vladimir Davydov
2019-02-26 12:10     ` [tarantool-patches] " Kirill Shcherbatov
2019-02-22 15:42 ` [PATCH v3 6/7] memtx: rename memtx_tree.c to memtx_tree_impl.h Kirill Shcherbatov
2019-02-22 15:42 ` [PATCH v3 7/7] memtx: introduce tuple compare hint Kirill Shcherbatov
2019-02-25 17:44   ` Vladimir Davydov
2019-02-26 12:10     ` [tarantool-patches] " Kirill Shcherbatov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225164658.GE2663@chai \
    --to=kostja.osipov@gmail.com \
    --cc=kshcherbatov@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v3 1/7] memtx: introduce universal iterator_pool' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox