Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@freelists.org, i.kosarev@corp.mail.ru,
	Ilya Kosarev <ilyanapar@yandex.ru>
Subject: Re: [PATCH v2] iproto: close socket explicitly before wal_dir at exit
Date: Mon, 25 Feb 2019 18:07:15 +0300	[thread overview]
Message-ID: <20190225150715.kpferqdtrf3deve3@esperanza> (raw)
In-Reply-To: <20190225145625.10840-1-i.kosarev@tarantool.org>

On Mon, Feb 25, 2019 at 05:56:25PM +0300, Ilya Kosarev wrote:
> From: Ilya Kosarev <ilyanapar@yandex.ru>
> 
> tarantool instance didn't close socket explicitly
> which could cause hot standby instance to fail to bind
> in case it tries to bind before socket is closed by OS.
> Now it is fixed by closing socket explicitly before wal_dir.
> 
> Closes #3967
> ---
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-3967-close-socket-explicitly
> https://github.com/tarantool/tarantool/issues/3967

Please write a brief change log whenever you resubmit a patch and bump
the version in the subject. For more details, see

https://tarantool.io/en/doc/1.10/dev_guide/developer_guidelines/#how-to-submit-a-patch-for-review

> 
>  src/box/box.cc    |  1 +
>  src/box/iproto.cc | 13 +++++++++++++
>  src/box/iproto.h  |  3 +++
>  3 files changed, 17 insertions(+)

I pushed the patch to 2.1 and 1.10. Thanks.

  reply	other threads:[~2019-02-25 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 14:56 Ilya Kosarev
2019-02-25 15:07 ` Vladimir Davydov [this message]
2019-02-25 16:50 ` [tarantool-patches] " Konstantin Osipov
2019-02-25 17:08   ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225150715.kpferqdtrf3deve3@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=i.kosarev@corp.mail.ru \
    --cc=i.kosarev@tarantool.org \
    --cc=ilyanapar@yandex.ru \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [PATCH v2] iproto: close socket explicitly before wal_dir at exit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox