Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@freelists.org,
	"Георгий Кириченко" <georgy@tarantool.org>
Subject: Re: [tarantool-patches] [PATCH v2] lua/fiber: Fix abort on malformed join input
Date: Mon, 25 Feb 2019 15:54:12 +0300	[thread overview]
Message-ID: <20190225125412.6cepuqwvdiutmdvt@esperanza> (raw)
In-Reply-To: <20190223133442.GC7198@uranus>

On Sat, Feb 23, 2019 at 04:34:42PM +0300, Cyrill Gorcunov wrote:
> If I create a new fiber and the join to himself we get an abort:
> 
>  | tarantool> f = require('fiber')
>  | ---
>  | ...
>  |
>  | tarantool> f.join(f.self())
>  | tarantool: src/fiber.c:407: fiber_join: Assertion `fiber->flags & FIBER_IS_JOINABLE' failed.
>  | Aborted (core dumped)
> 
> we should better throw an error.

Pushed to 2.1 and 1.10. Thanks!

> 
> v2: by georgy@
>  - add a testcase

We don't include changelog in the commit message. Please put it after
the diff separator (---) so that it is ignored by git-am.

> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>

We don't sign-off patches :-)

> ---
>  src/lua/fiber.c         |    6 +++++-
>  test/app/fiber.result   |   11 +++++++++++
>  test/app/fiber.test.lua |    7 +++++++
>  3 files changed, 23 insertions(+), 1 deletion(-)

  parent reply	other threads:[~2019-02-25 12:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 13:34 Cyrill Gorcunov
2019-02-23 19:49 ` [tarantool-patches] " Георгий Кириченко
2019-02-25 12:54 ` Vladimir Davydov [this message]
2019-02-25 13:12   ` [tarantool-patches] " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190225125412.6cepuqwvdiutmdvt@esperanza \
    --to=vdavydov.dev@gmail.com \
    --cc=georgy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH v2] lua/fiber: Fix abort on malformed join input' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox