From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 2/3] salad: do not touch struct heap_node.pos in user's code
Date: Mon, 25 Feb 2019 15:46:18 +0300 [thread overview]
Message-ID: <20190225124618.zt2szovg4rwbs6nf@esperanza> (raw)
In-Reply-To: <36f1e53ccc18d49524061ddc442cf6cb80e3ce4e.1550835301.git.v.shpilevoy@tarantool.org>
On Fri, Feb 22, 2019 at 02:38:59PM +0300, Vladislav Shpilevoy wrote:
> The only goal of reading and writing heap_node.pos was checking
> if a node is now in a heap, or not. This commit encapsulates this
> logic into a couple of functions.
Awesome, thanks. Pushed to 2.1.
(You forgot to push the branch to GitHub so applied the patch from this email).
next prev parent reply other threads:[~2019-02-25 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 11:38 [PATCH 0/3] Make heap API more friendly Vladislav Shpilevoy
2019-02-22 11:38 ` [PATCH 1/3] salad: make heap struct more friendly to use Vladislav Shpilevoy
2019-02-22 18:26 ` [tarantool-patches] " Konstantin Osipov
2019-02-22 18:38 ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-22 11:38 ` [PATCH 2/3] salad: do not touch struct heap_node.pos in user's code Vladislav Shpilevoy
2019-02-25 12:46 ` Vladimir Davydov [this message]
2019-02-22 11:39 ` [PATCH 3/3] salad: fix heap reserve() behaviour Vladislav Shpilevoy
2019-02-22 18:31 ` [tarantool-patches] " Konstantin Osipov
2019-02-22 18:38 ` [tarantool-patches] " Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225124618.zt2szovg4rwbs6nf@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [PATCH 2/3] salad: do not touch struct heap_node.pos in user'\''s code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox