From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Compute derived collation for concatenation
Date: Mon, 25 Feb 2019 14:29:36 +0300 [thread overview]
Message-ID: <20190225112936.7aciu2efh6kuteq5@tarantool.org> (raw)
In-Reply-To: <cover.1547644179.git.korablev@tarantool.org>
Hello,
On 16 Jan 16:13, Nikita Pettik wrote:
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3937-concatenation-collation
> Issue: https://github.com/tarantool/tarantool/issues/3937
>
> According to ANSI concatenation operator should derive collation
> from its operands. This small patch-set implements this procedure
> according to rules described in SQL standard.
>
> Nikita Pettik (2):
> sql: refactor sql_expr_coll and sql_binary_compare_coll_seq functions
> sql: compute resulting collation for concatenation
>
> src/box/sql/expr.c | 125 +++++++++++++++++++++++++++++---------------
> src/box/sql/select.c | 27 ++++++----
> src/box/sql/sqliteInt.h | 14 +++--
> src/box/sql/where.c | 56 ++++++++++----------
> src/box/sql/whereexpr.c | 23 ++++----
> test/sql/collation.result | 102 ++++++++++++++++++++++++++++++++++++
> test/sql/collation.test.lua | 46 ++++++++++++++++
> 7 files changed, 296 insertions(+), 97 deletions(-)
Your patches were pushed into 2.1 branch few days ago.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-02-25 11:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 13:13 [tarantool-patches] " Nikita Pettik
2019-01-16 13:13 ` [tarantool-patches] [PATCH 1/2] sql: refactor sql_expr_coll and sql_binary_compare_coll_seq functions Nikita Pettik
2019-01-17 13:28 ` [tarantool-patches] " Konstantin Osipov
2019-01-24 18:28 ` Vladislav Shpilevoy
2019-02-14 23:26 ` n.pettik
2019-01-16 13:13 ` [tarantool-patches] [PATCH 2/2] sql: compute resulting collation for concatenation Nikita Pettik
2019-01-17 13:33 ` [tarantool-patches] " Konstantin Osipov
2019-01-17 19:19 ` n.pettik
2019-01-18 9:59 ` Kirill Yukhin
2019-01-24 18:29 ` Vladislav Shpilevoy
2019-02-14 23:26 ` n.pettik
2019-02-22 11:23 ` Vladislav Shpilevoy
2019-02-22 13:40 ` n.pettik
2019-02-22 13:51 ` Vladislav Shpilevoy
2019-02-25 11:29 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225112936.7aciu2efh6kuteq5@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 0/2] Compute derived collation for concatenation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox