Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] vinyl: fix crash in run iterator due to uninitialized variable
Date: Sat, 23 Feb 2019 12:54:14 +0300	[thread overview]
Message-ID: <20190223095414.GA12939@chai> (raw)
In-Reply-To: <20190222211752.pfgav72gei2uczlh@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/23 12:44]:
> On Sat, Feb 23, 2019 at 12:17:30AM +0300, Vladimir Davydov wrote:
> > vy_run_iterator_seek left the return statement uninitialized under
> > certain conditions. The branch in the code wasn't covered by any test,
> > because it could only be triggered by an EQ SELECT following range
> > coalescing, so we only saw it when a customer reported a crash.
> > Fix it and improve vinyl/select_consistency test to cover this branch.
> 
> This one is urgent. Pushed to 2.1 and 1.10.
Thanks!


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2019-02-23  9:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 21:17 Vladimir Davydov
2019-02-22 21:17 ` Vladimir Davydov
2019-02-23  9:54   ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190223095414.GA12939@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] vinyl: fix crash in run iterator due to uninitialized variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox