Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com
Subject: Re: [tarantool-patches] [PATCH 3/3] salad: fix heap reserve() behaviour
Date: Fri, 22 Feb 2019 21:31:54 +0300	[thread overview]
Message-ID: <20190222183154.GC1691@chai> (raw)
In-Reply-To: <ab171778ca8a6c4eba05446a29d671a1f7f122fd.1550835301.git.v.shpilevoy@tarantool.org>

* Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/22 14:39]:
> Reserve() function by definition should ensure that there is
> enough space to store something. But heap reserve() always just
> increases the capacity twice. Even if there was already enough
> memory. Check for not necessary realloc was done out of this
> function. This was wrong. The commit makes reserve() be real
> reserve().
> 

OK to push.

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-02-22 18:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 11:38 [PATCH 0/3] Make heap API more friendly Vladislav Shpilevoy
2019-02-22 11:38 ` [PATCH 1/3] salad: make heap struct more friendly to use Vladislav Shpilevoy
2019-02-22 18:26   ` [tarantool-patches] " Konstantin Osipov
2019-02-22 18:38     ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-22 11:38 ` [PATCH 2/3] salad: do not touch struct heap_node.pos in user's code Vladislav Shpilevoy
2019-02-25 12:46   ` Vladimir Davydov
2019-02-22 11:39 ` [PATCH 3/3] salad: fix heap reserve() behaviour Vladislav Shpilevoy
2019-02-22 18:31   ` Konstantin Osipov [this message]
2019-02-22 18:38     ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222183154.GC1691@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] [PATCH 3/3] salad: fix heap reserve() behaviour' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox