From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Георгий Кириченко" <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [RFC] fiber: Increase default stack size
Date: Fri, 22 Feb 2019 10:46:07 +0300 [thread overview]
Message-ID: <20190222074607.GU7198@uranus> (raw)
In-Reply-To: <7936473.6eviP72C8M@home.lan>
On Fri, Feb 22, 2019 at 10:38:42AM +0300, Георгий Кириченко wrote:
> Hi Cyrill!
Hi!
> Thanks for the patch, please see some comments bellow.
> I like your approach but I think we should do it in a different manner: we
> could poison 64k page of a fiber stack on start and then check the poison mark
> when fiber finished. If watermark was overwritten by fiber activity we could use
> madvise in order to decrease RSS usage.
I somehow fail to see how it is different from the current scheme.
In the patch we put single 8 16 bytes poison at 64K (well, page
aligned offset to be precise) and once the fiber scheduled out we
test it. I suspect the difference you mean is to _when_ test the poison?
Or you mean to poison the whole 64K?
p.s.
You know, I think this stack limits *must not* be fixed in size but
rather configurable from some parameters (getenv or something). Otherwise
it will be an endless run and catch game.
next prev parent reply other threads:[~2019-02-22 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 21:26 Cyrill Gorcunov
2019-02-22 7:38 ` [tarantool-patches] " Георгий Кириченко
2019-02-22 7:46 ` Cyrill Gorcunov [this message]
2019-02-22 9:24 ` Георгий Кириченко
2019-02-22 9:45 ` Cyrill Gorcunov
2019-02-22 10:48 ` [tarantool-patches] " Alexander Turenko
2019-02-22 10:57 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222074607.GU7198@uranus \
--to=gorcunov@gmail.com \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [RFC] fiber: Increase default stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox