Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] sql: fix grammar for foreign key actions
Date: Fri, 22 Feb 2019 09:48:37 +0300	[thread overview]
Message-ID: <20190222064837.hw5o6cpeorjkjnfq@tarantool.org> (raw)
In-Reply-To: <20190222005200.26374-1-korablev@tarantool.org>

Hello,

On 22 Feb 03:52, Nikita Pettik wrote:
> SQLite grammar implementing foreign keys parsing is quite compact, but
> on the other hand it allows to define ON DELETE and ON UPDATE actions
> multiple times. For instance:
> 
> ... REFERENCES t ON DELETE CASCADE ON DELETE RESTRICT;
> 
> It makes no sense and contradicts original ANSI syntax. So, lets rework
> it a bit. Firstly, MATCH clause must come first, so we place it in
> independent rule. Then we remove ON INSERT clause, since there is no
> such opportunity at all. Finally, we have only 4 options to expose
> refargs (i.e. grammar rule to parse FK actions): ON UPDATE, ON DELETE,
> ON UPDATE ON DELETE, ON DELETE ON UPDATE. That's it.
> 
> Closes #3475
> ---
> Branch: https://github.com/tarantool/tarantool/commits/np/gh-3475-fix-fk-grammar
> Issue: https://github.com/tarantool/tarantool/issues/3475

I've checked your patch into 2.1 branch.

--
Regards, Kirill Yukhin

      reply	other threads:[~2019-02-22  6:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22  0:52 [tarantool-patches] " Nikita Pettik
2019-02-22  6:48 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222064837.hw5o6cpeorjkjnfq@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: fix grammar for foreign key actions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox