From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org, kostja@tarantool.org
Subject: Re: [PATCH v2 1/4] box: move memtx_tree implementation to source file
Date: Thu, 21 Feb 2019 16:26:54 +0300 [thread overview]
Message-ID: <20190221132654.hbaanli7s3ey4f2w@esperanza> (raw)
In-Reply-To: <0e4dceb9b4dd6ae72bca08823ad7b5a8a6f85ce6.1550050245.git.kshcherbatov@tarantool.org>
The subject line prefix should be 'memtx:' I think.
On Wed, Feb 13, 2019 at 12:32:25PM +0300, Kirill Shcherbatov wrote:
> Refactored memtx_tree code so that memtx_tree.h contained only
> the signature of the tree object constructor memtx_tree_index_new,
> while all implementation details were in memtx_tree.c.
> This will further allow to template the implementation details.
>
> Needed for #3961
> ---
> src/box/memtx_tree.c | 62 ++++++++++++++++++++++++++++++++++++++--
> src/box/memtx_tree.h | 68 ++------------------------------------------
> 2 files changed, 63 insertions(+), 67 deletions(-)
The patch is good, but I think we shouldn't stop at memtx_tree and do
the same for other memtx indexes - hash, bitset, rtree. Please do it in
the scope of this patch.
next prev parent reply other threads:[~2019-02-21 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:32 [PATCH v2 0/4] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-02-13 9:32 ` [PATCH v2 1/4] box: move memtx_tree implementation to source file Kirill Shcherbatov
2019-02-14 13:57 ` [tarantool-patches] " Konstantin Osipov
2019-02-21 13:26 ` Vladimir Davydov [this message]
2019-02-13 9:32 ` [PATCH v2 2/4] box: rework memtx_tree to store arbitrary nodes Kirill Shcherbatov
2019-02-21 15:01 ` Vladimir Davydov
2019-02-13 9:32 ` [PATCH v2 3/4] box: rename memtx_tree.c to memtx_tree_impl.h Kirill Shcherbatov
2019-02-13 9:32 ` [PATCH v2 4/4] box: introduce tuple compare hint for string index Kirill Shcherbatov
2019-02-14 14:09 ` [tarantool-patches] " Konstantin Osipov
2019-02-15 18:34 ` Kirill Shcherbatov
2019-02-19 15:01 ` [tarantool-patches] " Konstantin Osipov
2019-02-19 15:02 ` Kirill Shcherbatov
2019-02-21 16:06 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221132654.hbaanli7s3ey4f2w@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 1/4] box: move memtx_tree implementation to source file' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox