From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: rework "no such object" and "object exists" errors
Date: Tue, 19 Feb 2019 18:04:41 +0300 [thread overview]
Message-ID: <20190219150441.GC2503@chai> (raw)
In-Reply-To: <43CF0F9C-EC0A-4C04-A60F-2103CBBE3CAA@tarantool.org>
* n.pettik <korablev@tarantool.org> [19/02/18 15:16]:
>
>
> > On 15 Feb 2019, at 20:14, imeevma@tarantool.org wrote:
> >
> > Hi! Thank you for review. My answers and new version below. There
> > will not be diff between versions because the only meaningful fix
> > was turned into new patch in the patch-set.
>
> Ok, if Konstantin and you consider my comments as minor ones,
> then I don’t mind if this part is pushed to 2.1 (Travis is OK, refactoring
> is obvious).
>
> Kirill, could you do this?
I assume your comments are being worked on in separate commits.
>
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-19 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 17:14 [tarantool-patches] [PATCH v2 0/2] sql: use diag_set() for errors in SQL imeevma
2019-02-15 17:14 ` [tarantool-patches] [PATCH v2 1/2] sql: remove field suppressErr from struct sql imeevma
2019-02-15 17:14 ` [tarantool-patches] [PATCH v2 2/2] sql: rework "no such object" and "object exists" errors imeevma
2019-02-18 12:14 ` [tarantool-patches] " n.pettik
2019-02-19 15:04 ` Konstantin Osipov [this message]
2019-02-18 16:51 ` [tarantool-patches] Re: [PATCH v2 0/2] sql: use diag_set() for errors in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219150441.GC2503@chai \
--to=kostja@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 2/2] sql: rework "no such object" and "object exists" errors' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox