Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: vdavydov.dev@gmail.com, Alexandr Lyapunov <aleks@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v2 4/4] box: introduce tuple compare hint for string index
Date: Tue, 19 Feb 2019 18:01:56 +0300	[thread overview]
Message-ID: <20190219150156.GB2503@chai> (raw)
In-Reply-To: <414fffe7-3d58-fd42-3334-d7072c78afb4@tarantool.org>

* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/02/15 21:36]:
> Hi! I've implemented Kostya's concepts for compatible hints for UINT/INT.
> Also fixed nullability troubles. Now alter looks fine for me.
> I've thought about number/integer convertions, but such alter would not pass,
> I guess.
> 

Do you have tests for this or have you checked that specific tests
exist? E.g. when tuple hint is used *and* we change nullability
back and forth.

BTW, have you checked changes in collation, do they work?


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  reply	other threads:[~2019-02-19 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13  9:32 [PATCH v2 0/4] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-02-13  9:32 ` [PATCH v2 1/4] box: move memtx_tree implementation to source file Kirill Shcherbatov
2019-02-14 13:57   ` [tarantool-patches] " Konstantin Osipov
2019-02-21 13:26   ` Vladimir Davydov
2019-02-13  9:32 ` [PATCH v2 2/4] box: rework memtx_tree to store arbitrary nodes Kirill Shcherbatov
2019-02-21 15:01   ` Vladimir Davydov
2019-02-13  9:32 ` [PATCH v2 3/4] box: rename memtx_tree.c to memtx_tree_impl.h Kirill Shcherbatov
2019-02-13  9:32 ` [PATCH v2 4/4] box: introduce tuple compare hint for string index Kirill Shcherbatov
2019-02-14 14:09   ` [tarantool-patches] " Konstantin Osipov
2019-02-15 18:34   ` Kirill Shcherbatov
2019-02-19 15:01     ` Konstantin Osipov [this message]
2019-02-19 15:02     ` [tarantool-patches] " Kirill Shcherbatov
2019-02-21 16:06       ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219150156.GB2503@chai \
    --to=kostja@tarantool.org \
    --cc=aleks@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=vdavydov.dev@gmail.com \
    --subject='Re: [tarantool-patches] Re: [PATCH v2 4/4] box: introduce tuple compare hint for string index' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox