From: Konstantin Osipov <kostja@tarantool.org> To: tarantool-patches@freelists.org Cc: Georgy Kirichenko <georgy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v3 1/2] Journal transaction boundaries Date: Tue, 19 Feb 2019 17:59:19 +0300 [thread overview] Message-ID: <20190219145919.GA2503@chai> (raw) In-Reply-To: <20190215131541.u64sjmsrjkkxqixy@esperanza> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/15 16:17]: > > + /* 0x08 */ MP_UINT, /* IPROTO_TXN_ID */ > > + /* 0x09 */ MP_UINT, /* IPROTO_TXN_FLAGS */ > > I don't quite like the name, because we encode not a txn id, but the > statement number in a txn. Let's rename it to IPROTO_TXN_STMT_NO or > IPROTO_TXN_STMT_ID or IPROTO_TXN_STMT_SEQ? How about IRPOTO_TSN and IPROTO_FLAGS? > > +enum { > > + /** Set for the last xrow in a transaction. */ > > + TXN_FLAG_COMMIT = 0x01, > > IPROTO_TXN_COMMIT? IRPOTO_FLAG_COMMIT? -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-19 14:59 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <cover.1550001848.git.georgy@tarantool.org> 2019-02-12 20:04 ` [tarantool-patches] " Georgy Kirichenko 2019-02-15 13:15 ` Vladimir Davydov 2019-02-19 14:59 ` Konstantin Osipov [this message] 2019-02-12 20:04 ` [tarantool-patches] [PATCH v3 2/2] Transaction support for applier Georgy Kirichenko 2019-02-18 9:36 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190219145919.GA2503@chai \ --to=kostja@tarantool.org \ --cc=georgy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v3 1/2] Journal transaction boundaries' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox