From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org,
Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: disable sparse optimization in box.tuple.new()
Date: Mon, 18 Feb 2019 11:45:16 +0300 [thread overview]
Message-ID: <20190218084516.vydmk2apw34lnnbc@tarantool.org> (raw)
In-Reply-To: <38d2414b18464bc28be295281de1779fd7cfb1cc.1549881301.git.kshcherbatov@tarantool.org>
Hello,
On 11 Feb 13:43, Kirill Shcherbatov wrote:
> The box.tuple.new() used to call luamp_encode_tuple with
> default LUA serializer config 'luaL_msgpack_default'. This
> routine may consider an array to be excessively sparse when
> + encode_sparse_ratio > 0
> + max(table) > encode_sparse_safe
> + max(table) > count(table) * encode_sparse_ratio.
> Sparse optimization save memory via representing excessively
> sparse tuple as MP_MAP. But Tarantool tuple always must be
> MP_ARRAY so it is not relevant for box.tuple.new semantics.
> So it is disabled with encode_sparse_ratio = 0 in a new local
> serializer config.
>
> Closes #3882
I've checked your patch into 1.10 and 2.1 branches.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-02-18 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 10:43 [tarantool-patches] " Kirill Shcherbatov
2019-02-12 11:18 ` [tarantool-patches] " Kirill Shcherbatov
2019-02-12 11:33 ` [tarantool-patches] " Konstantin Osipov
2019-02-12 17:50 ` Vladislav Shpilevoy
2019-02-13 12:19 ` Konstantin Osipov
2019-02-15 15:17 ` Kirill Shcherbatov
2019-02-15 21:31 ` Vladislav Shpilevoy
2019-02-18 8:45 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218084516.vydmk2apw34lnnbc@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] box: disable sparse optimization in box.tuple.new()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox