From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 2/3] box: don't set cluster uuid and instance id in initial snapshot
Date: Fri, 15 Feb 2019 15:58:34 +0300 [thread overview]
Message-ID: <20190215125834.GA24683@chai> (raw)
In-Reply-To: <2686110152a446ba3d039cf0a644b1c6d102f813.1550232829.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/15 15:26]:
> They aren't needed there as we reset them anyway once the snapshot is
> replayed on initial bootstrap. OTOH having them results in calling
> replica_{set,clear}_id twice on initial bootstrap, which will look weird
> when I patch them to log the ids. So let's remove them from the initial
> snapshot. This makes the initial bootstrap impossible to recover from as
> it is, but that shouldn't be an issue since one can always bootstrap a
> new instance in a normal way. This also allows us to make cluster uuid
> truly immutable (currently, one can update it with REPLACE).
This patch is Ok to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-15 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 12:25 [PATCH v2 0/3] Improve replication related logging Vladimir Davydov
2019-02-15 12:25 ` [PATCH v2 1/3] vclock: use static buffer to format vclock Vladimir Davydov
2019-02-15 12:41 ` Konstantin Osipov
2019-02-15 12:25 ` [PATCH v2 2/3] box: don't set cluster uuid and instance id in initial snapshot Vladimir Davydov
2019-02-15 12:58 ` Konstantin Osipov [this message]
2019-02-15 13:00 ` [tarantool-patches] " Konstantin Osipov
2019-02-15 12:25 ` [PATCH v2 3/3] replication: improve join/subscribe logging Vladimir Davydov
2019-02-15 12:59 ` [tarantool-patches] " Konstantin Osipov
2019-02-15 12:26 ` [PATCH v2 0/3] Improve replication related logging Vladimir Davydov
2019-02-15 13:47 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215125834.GA24683@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 2/3] box: don'\''t set cluster uuid and instance id in initial snapshot' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox