From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: kostja@tarantool.org
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] replication: improve join/subscribe logging
Date: Fri, 15 Feb 2019 12:42:11 +0300 [thread overview]
Message-ID: <20190215094211.kill6uborsmewl6w@esperanza> (raw)
In-Reply-To: <b669aade505676e8ae9a9df848bb0a3a767cc125.1550166139.git.vdavydov.dev@gmail.com>
On Thu, Feb 14, 2019 at 08:44:36PM +0300, Vladimir Davydov wrote:
> This patch makes logging a little bit more verbose so as to facilitate
> post-mortem replication failure analysis:
>
> - When an instance starts up, print its uuid and vclock.
> - When a replica connects to a master, print the master's uuid.
> - Log join/subscribe events in the master's log; print replica uuid,
> address, and vclock.
Come to think of it, we also need to print id assigned to
each replica, otherwise vclocks wouldn't make much sense.
I'll patch replica_{set,clear}_id in v2.
Also, we should probably be more verbose in applier as well
and print local and remote vclocks when an applier subscribes.
Will do it, too.
prev parent reply other threads:[~2019-02-15 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 17:44 Vladimir Davydov
2019-02-15 9:42 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215094211.kill6uborsmewl6w@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] replication: improve join/subscribe logging' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox