From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: fix crash if iterator is used throughout DDL
Date: Thu, 14 Feb 2019 17:57:28 +0300 [thread overview]
Message-ID: <20190214145728.3fbqtpthggcekpbs@esperanza> (raw)
In-Reply-To: <20190214135446.GB17583@chai>
On Thu, Feb 14, 2019 at 04:54:46PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/14 16:23]:
> > vy_run_iterator doesn't take a reference to the format it uses to decode
> > statements loaded from disk. As a result, the format may be deleted by
> > DDL, leading to a use-after-free bug. Fix this by taking a reference to
> > the format used by an iterator.
>
> Please add a comment before _ref():
>
> /*
> * Please remove this kludge when proper DDL locking is
> * implemented on transaction management level or multi-version
> * data dictionary is in place.
> */
> >
>
> With that, oK to push.
Pushed to 2.1 and 1.10.
prev parent reply other threads:[~2019-02-14 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:18 Vladimir Davydov
[not found] ` <20190214135446.GB17583@chai>
2019-02-14 14:57 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214145728.3fbqtpthggcekpbs@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: fix crash if iterator is used throughout DDL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox