Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] Emit NOPs in case of a replication conflict
Date: Tue, 12 Feb 2019 22:29:21 +0300	[thread overview]
Message-ID: <20190212192921.GC10042@chai> (raw)
In-Reply-To: <49a2387ecbdb9d0a98090e37b11af09dfea720a5.1549983926.git.georgy@tarantool.org>

* Georgy Kirichenko <georgy@tarantool.org> [19/02/12 18:09]:
>  				struct error *e = diag_last_error(diag_get());
>  				/**
> -				 * Silently skip ER_TUPLE_FOUND error if such
> -				 * option is set in config.
> +				 * In case of ER_TUPLE_FOUND error replca row
> +				 * with nop if such option is set in config.

Please fix the comment. replca -> replica, the English grammar is
not looking proper to me.

Let's write something along these lines:

In case of ER_TUPLE_FOUND error and replication_skip_conflict
configuration error, skip applying the foreign row and replace it
with NOP in the local write ahead log.

Otherwise the patch is OK to push.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2019-02-12 19:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 15:07 [tarantool-patches] " Georgy Kirichenko
2019-02-12 19:29 ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190212192921.GC10042@chai \
    --to=kostja@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH] Emit NOPs in case of a replication conflict' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox