From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH] vinyl: cancel reader and writer threads on shutdown
Date: Tue, 12 Feb 2019 12:02:24 +0300 [thread overview]
Message-ID: <20190212090224.5mbvhbxsiqs6kgfk@esperanza> (raw)
In-Reply-To: <20190211181605.GB9960@chai>
On Mon, Feb 11, 2019 at 09:16:05PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/11 20:41]:
> > Currently, vinyl won't shutdown until all reader and writer threads
> > gracefully complete all their pending requests, which may take a while,
> > especially for writer threads that may happen to be doing compaction at
> > the time. This is annoying - there's absolutely no reason to delay
> > termination in such a case. Let's forcefully cancel all threads, like we
> > do in case of relay threads.
> >
> > This should fix sporadic vinyl/replica_quota test hang.
> >
> > Closes #3949
>
> OK to push.
Pushed to 2.1 and 1.10.
prev parent reply other threads:[~2019-02-12 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 17:37 Vladimir Davydov
2019-02-11 18:16 ` Konstantin Osipov
2019-02-12 9:02 ` Vladimir Davydov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212090224.5mbvhbxsiqs6kgfk@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH] vinyl: cancel reader and writer threads on shutdown' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox