From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v1 2/4] box: rework memtx_tree class to be reusable
Date: Mon, 11 Feb 2019 18:49:15 +0300 [thread overview]
Message-ID: <20190211154915.fhqiztrxlvs4xuto@esperanza> (raw)
In-Reply-To: <3dde48d41f6cc51483837242af8d6d4873526445.1549367041.git.kshcherbatov@tarantool.org>
On Tue, Feb 05, 2019 at 02:58:37PM +0300, Kirill Shcherbatov wrote:
> The memtx tree class has been redesigned so that it can be used
> to store arbitrary structures in the future. This makes possible
> to implement type hints in memtx in subsequent patches.
>
> Needed for #3961
> ---
> src/box/memtx_tree.c | 715 ++--------------------------
> src/box/memtx_tree.h | 68 +--
> src/box/memtx_tree_impl.h | 960 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1008 insertions(+), 735 deletions(-)
> create mode 100644 src/box/memtx_tree_impl.h
You move a huge chunk of code to another file and modify it at the same
time, which makes the patch impossible to review. Please split it in
two. First, do the necessary modifications in memtx_tree.c (it's OK to
include *.c files in C), then rename memtx_tree.c to memtx_tree_impl.h.
next prev parent reply other threads:[~2019-02-11 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 11:58 [PATCH v1 0/4] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-02-05 11:58 ` [PATCH v1 1/4] lib: introduce BPS_TREE_EQUAL custom comparator Kirill Shcherbatov
2019-02-11 15:46 ` Vladimir Davydov
2019-02-05 11:58 ` [PATCH v1 2/4] box: rework memtx_tree class to be reusable Kirill Shcherbatov
2019-02-11 15:49 ` Vladimir Davydov [this message]
2019-02-05 11:58 ` [PATCH v1 3/4] box: introduce tuple compare hint Kirill Shcherbatov
2019-02-11 15:57 ` Vladimir Davydov
2019-02-05 11:58 ` [PATCH v1 4/4] box: introduce hint option for memtx tree index Kirill Shcherbatov
2019-02-11 16:12 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211154915.fhqiztrxlvs4xuto@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v1 2/4] box: rework memtx_tree class to be reusable' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox