From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2] box: enable WAL before making initial checkpoint
Date: Mon, 11 Feb 2019 15:41:56 +0300 [thread overview]
Message-ID: <20190211124156.GB20767@chai> (raw)
In-Reply-To: <c099e59797b33001cb941030285593da2d839941.1549884735.git.vdavydov.dev@gmail.com>
* Vladimir Davydov <vdavydov.dev@gmail.com> [19/02/11 15:34]:
> While a replica is bootstrapped from a remote master, vinyl engine
> may need to perform compaction, which means that it may write to
> the _vinyl_deferred_delete system space. Compaction proceeds fully
> asynchronously, i.e. a write may occur after the join stage is
> complete, but before the WAL is initialized, in which case the new
> replica will crash. To make sure a race like that won't happen, let's
> setup WAL before making the initial checkpoint. The WAL writer is now
> initialized right before starting the WAL thread and so we don't need
> to split WAL struct into the thread and the writer anymore.
>
> Closes #3968
OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-11 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 16:51 [PATCH] box: delay all writes before wal writer is initialized Vladimir Davydov
2019-02-11 12:34 ` [PATCH v2] box: enable WAL before making initial checkpoint Vladimir Davydov
2019-02-11 12:41 ` Konstantin Osipov [this message]
2019-02-11 14:10 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211124156.GB20767@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH v2] box: enable WAL before making initial checkpoint' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox