From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v2 3/8] vinyl: rename lsm->range_heap to max_compaction_priority
Date: Fri, 8 Feb 2019 20:26:26 +0300 [thread overview]
Message-ID: <20190208172626.in2jg3rjlevkl77m@esperanza> (raw)
In-Reply-To: <20190208171946.GH4588@chai>
On Fri, Feb 08, 2019 at 08:19:46PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [19/01/24 20:16]:
> > The name 'range_heap' is ambiguous, because it's unclear what range
> > should be on top of the heap. We need to introduce another heap of
> > ranges ordered differently, so let's rename to max_compaction_priority
> > to avoid confusion.
>
> I think the old name was better. And I think we could avoid
> introducing another heap ;)
Yep, I removed the heap in the new version and left the old name.
See the branch pls.
next prev parent reply other threads:[~2019-02-08 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 17:12 [PATCH v2 0/8] vinyl: compaction randomization and throttling Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 1/8] vinyl: use uncompressed run size for range split/coalesce/compaction Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 2/8] vinyl: fix compaction priority calculation Vladimir Davydov
2019-02-08 17:18 ` [tarantool-patches] " Konstantin Osipov
2019-02-11 14:42 ` Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 3/8] vinyl: rename lsm->range_heap to max_compaction_priority Vladimir Davydov
2019-02-08 17:19 ` [tarantool-patches] " Konstantin Osipov
2019-02-08 17:26 ` Vladimir Davydov [this message]
2019-01-24 17:12 ` [PATCH v2 4/8] vinyl: keep track of dumps per compaction for each LSM tree Vladimir Davydov
2019-02-08 17:42 ` Vladimir Davydov
2019-02-11 18:17 ` [tarantool-patches] " Konstantin Osipov
2019-02-11 18:17 ` Konstantin Osipov
2019-02-12 10:15 ` Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 5/8] vinyl: set range size automatically Vladimir Davydov
2019-02-11 18:21 ` [tarantool-patches] " Konstantin Osipov
2019-02-12 10:16 ` Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 6/8] vinyl: randomize range compaction to avoid IO load spikes Vladimir Davydov
2019-02-11 18:21 ` [tarantool-patches] " Konstantin Osipov
2019-02-12 10:16 ` Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 7/8] vinyl: introduce quota consumer types Vladimir Davydov
2019-02-12 15:48 ` Vladimir Davydov
2019-01-24 17:12 ` [PATCH v2 8/8] vinyl: throttle tx to ensure compaction keeps up with dumps Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208172626.in2jg3rjlevkl77m@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v2 3/8] vinyl: rename lsm->range_heap to max_compaction_priority' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox