From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 4/5] Emit NOP if an applier skips row
Date: Fri, 8 Feb 2019 19:50:40 +0300 [thread overview]
Message-ID: <20190208165040.GB4588@chai> (raw)
In-Reply-To: <98c96d540bd0d23cdbdf42bb0d91c699afdd3e70.1548152776.git.georgy@tarantool.org>
* Georgy Kirichenko <georgy@tarantool.org> [19/01/22 15:45]:
> */
> - if (e->type == &type_ClientError &&
> - box_error_code(e) == ER_TUPLE_FOUND &&
> - replication_skip_conflict)
> - diag_clear(diag_get());
> - else {
> - /* Rollback lsn to have a chance for a retry. */
> - vclock_set(&replicaset.applier.vclock,
> - row.replica_id, old_lsn);
> - latch_unlock(latch);
> - diag_raise();
> - }
> + diag_clear(diag_get());
> + row.type = IPROTO_NOP;
> + row.bodycnt = 0;
> + res = xstream_write(applier->subscribe_stream,
> + &row);
> + }
> + if (res != 0) {
> + /* Rollback lsn to have a chance for a retry. */
> + vclock_set(&replicaset.applier.vclock,
> + row.replica_id, old_lsn);
> + latch_unlock(latch);
> + diag_raise();
> }
Why do you need to manually promote applier.vclock here?
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-08 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 10:31 [tarantool-patches] [PATCH v2 0/5] Strong sequentially LSN in journal Georgy Kirichenko
2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 1/5] Do not promote wal vclock for failed writes Georgy Kirichenko
2019-01-28 11:20 ` Vladimir Davydov
2019-01-29 10:22 ` Георгий Кириченко
2019-01-29 11:58 ` Vladimir Davydov
2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 2/5] Update replicaset vclock from wal Georgy Kirichenko
2019-01-28 11:59 ` Vladimir Davydov
2019-01-29 10:33 ` [tarantool-patches] " Георгий Кириченко
2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 3/5] Enforce applier out of order protection Georgy Kirichenko
2019-01-28 12:09 ` Vladimir Davydov
2019-01-29 10:30 ` [tarantool-patches] " Георгий Кириченко
2019-01-29 12:00 ` Vladimir Davydov
2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 4/5] Emit NOP if an applier skips row Georgy Kirichenko
2019-01-28 12:15 ` Vladimir Davydov
2019-02-08 16:50 ` Konstantin Osipov [this message]
2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 5/5] Disallow lsn gaps while vclock following Georgy Kirichenko
2019-01-28 12:18 ` Vladimir Davydov
2019-01-28 11:15 ` [tarantool-patches] [PATCH v2 0/5] Strong sequentially LSN in journal Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208165040.GB4588@chai \
--to=kostja@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 4/5] Emit NOP if an applier skips row' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox