Re: [tarantool-patches] [PATCH v2 0/2] Do not promote vclocks in case of failure

[Vladimir Davydov <vdavydov.dev@gmail.com>]

On Thu, Feb 07, 2019 at 08:27:29PM +0300, Georgy Kirichenko wrote:
> Promote tx and wal vclock only if corresponding row was successfully
> written to wal. This prevents tarantool from skipping rows in case of
> replication errors as well as from making lsn gaps after IO errors.
> 
> Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-2283-dont-skip-rows-after-errors
> Issue: https://github.com/tarantool/tarantool/issues/2283
> 
> Changes in v2:
>   - commits 2 and 3 are squashed
>   - test fixed according to review
>   - comment fixed according to review
> 
> Georgy Kirichenko (2):
>   Do not promote wal vclock for failed writes
>   Promote replicaset.vclock only after wal
> 
>  src/box/applier.cc                          |  46 +--
>  src/box/wal.c                               |  67 ++--
>  test/box/errinj.result                      |  59 +++
>  test/box/errinj.test.lua                    |  20 ++
>  test/replication/skip_conflict_row.result   |  63 ++++
>  test/replication/skip_conflict_row.test.lua |  20 ++
>  test/xlog/errinj.result                     |   1 -
>  test/xlog/panic_on_lsn_gap.result           | 377 --------------------
>  test/xlog/panic_on_lsn_gap.test.lua         | 136 -------
>  9 files changed, 210 insertions(+), 579 deletions(-)
>  delete mode 100644 test/xlog/panic_on_lsn_gap.result
>  delete mode 100644 test/xlog/panic_on_lsn_gap.test.lua

Pushed to 2.1 and 1.10.