From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Stanislav Zudin <szudin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2] sql: prohibit negative values under LIMIT clause
Date: Thu, 7 Feb 2019 11:53:57 +0300 [thread overview]
Message-ID: <20190207085357.z33fbniyn5sk4bj5@tarantool.org> (raw)
In-Reply-To: <20190205085636.19053-1-szudin@tarantool.org>
Hello,
On 05 Feb 11:56, Stanislav Zudin wrote:
> If LIMIT or OFFSET expressions can be casted to the
> negative integer value VDBE returns an error.
> If expression in the LIMIT clause can't be converted
> into integer without data loss the VDBE instead of
> SQLITE_MISMATCH returns SQL_TARANTOOL_ERROR with
> message "Only positive numbers are allowed in the
> LIMIT clause". The same for OFFSET clause.
>
> Closes #3467
> ---
> Branch: https://github.com/tarantool/tarantool/tree/stanztt/gh-3467-prohibit-negative-limits
> Issue: https://github.com/tarantool/tarantool/issues/3467
I've checked your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-02-07 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 8:56 [tarantool-patches] " Stanislav Zudin
2019-02-05 15:15 ` [tarantool-patches] " n.pettik
2019-02-05 19:51 ` Stanislav Zudin
2019-02-06 13:25 ` n.pettik
2019-02-07 8:53 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207085357.z33fbniyn5sk4bj5@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=korablev@tarantool.org \
--cc=szudin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2] sql: prohibit negative values under LIMIT clause' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox