From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v9 2/6] box: introduce tuple_field_raw_by_path routine
Date: Mon, 4 Feb 2019 13:37:23 +0300 [thread overview]
Message-ID: <20190204103723.irhsaoroiqaf3wal@esperanza> (raw)
In-Reply-To: <8637583706afb4df090124ecf5d498b40a3c28fc.1549187339.git.kshcherbatov@tarantool.org>
On Sun, Feb 03, 2019 at 01:20:22PM +0300, Kirill Shcherbatov wrote:
> Introduced a new function tuple_field_raw_by_path is used to get
> tuple fields by field index and relative JSON path. This routine
> uses tuple_format's field_map if possible. It will be further
> extended to use JSON indexes.
> The old tuple_field_raw_by_path routine used to work with full
> JSON paths, renamed tuple_field_raw_by_full_path. It's return
> value type is changed to const char * because the other similar
> functions tuple_field_raw and tuple_field_by_part_raw use this
> convention.
> Got rid of reporting error position for 'invalid JSON path' error
> in lbox_tuple_field_by_path because we can't extend other
> routines to behave such way that makes an API inconsistent,
> moreover such error are useless and confusing.
>
> Needed for #1012
> ---
> src/box/lua/tuple.c | 9 +--
> src/box/tuple.h | 60 +++++++++---------
> src/box/tuple_format.c | 63 ++++++-------------
> src/box/tuple_format.h | 127 +++++++++++++++++++++------------------
> test/engine/tuple.result | 16 ++---
> 5 files changed, 129 insertions(+), 146 deletions(-)
Pushed to 2.1.
next prev parent reply other threads:[~2019-02-04 10:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 10:20 [PATCH v9 0/6] box: Indexes by JSON path Kirill Shcherbatov
2019-02-03 10:20 ` [PATCH v9 1/6] lib: update msgpuck library Kirill Shcherbatov
2019-02-04 9:48 ` Vladimir Davydov
2019-02-03 10:20 ` [PATCH v9 2/6] box: introduce tuple_field_raw_by_path routine Kirill Shcherbatov
2019-02-04 10:37 ` Vladimir Davydov [this message]
2019-02-03 10:20 ` [PATCH v9 3/6] box: introduce JSON Indexes Kirill Shcherbatov
2019-02-04 12:26 ` Vladimir Davydov
2019-02-03 10:20 ` [PATCH v9 4/6] box: introduce has_json_paths flag in templates Kirill Shcherbatov
2019-02-04 12:31 ` Vladimir Davydov
2019-02-03 10:20 ` [PATCH v9 5/6] box: introduce offset_slot cache in key_part Kirill Shcherbatov
2019-02-04 12:56 ` Vladimir Davydov
2019-02-04 13:02 ` [tarantool-patches] " Kirill Shcherbatov
2019-02-04 15:10 ` Vladimir Davydov
2019-02-03 10:20 ` [PATCH v9 6/6] box: specify indexes in user-friendly form Kirill Shcherbatov
2019-02-04 15:30 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204103723.irhsaoroiqaf3wal@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v9 2/6] box: introduce tuple_field_raw_by_path routine' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox