From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH] tuple: fix hashing of integer numbers
Date: Tue, 29 Jan 2019 16:33:14 +0300 [thread overview]
Message-ID: <20190129133314.6d3rvqfxgo7ozgak@tarantool.org> (raw)
In-Reply-To: <3bb1fa694ee45642ab6b3c09926f3c577a109fab.1548171646.git.vdavydov.dev@gmail.com>
Hello Vladimir,
On 22 Jan 19:13, Vladimir Davydov wrote:
> Integer numbers stored in tuples as MP_FLOAT/MP_DOUBLE are hashed
> differently from integer numbers stored as MP_INT/MP_UINT. This breaks
> select() for memtx hash indexes and vinyl indexes (the latter use bloom
> filters). Fix this by converting MP_FLOAT/MP_DOUBLE to MP_INT/MP_UINT
> before hashing if the value can be stored as an integer. This is
> consistent with the behavior of tuple comparators, which treat MP_FLOAT
> and MP_INT as equal in case they represent the same number.
>
> Closes #3907
> ---
> https://github.com/tarantool/tarantool/issues/3907
> https://github.com/tarantool/tarantool/commits/dv/gh-3907-fix-integer-number-hashing
I've checked your patch into 2.1 branch.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2019-01-29 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 16:13 Vladimir Davydov
2019-01-29 13:33 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129133314.6d3rvqfxgo7ozgak@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] tuple: fix hashing of integer numbers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox