From: Vladimir Davydov <vdavydov.dev@gmail.com> To: Georgy Kirichenko <georgy@tarantool.org> Cc: tarantool-patches@freelists.org Subject: Re: [tarantool-patches] [PATCH v2 4/5] Emit NOP if an applier skips row Date: Mon, 28 Jan 2019 15:15:40 +0300 [thread overview] Message-ID: <20190128121540.gppxu7f544wgpi67@esperanza> (raw) In-Reply-To: <98c96d540bd0d23cdbdf42bb0d91c699afdd3e70.1548152776.git.georgy@tarantool.org> On Tue, Jan 22, 2019 at 01:31:12PM +0300, Georgy Kirichenko wrote: > Fill lsn gaps with NOP rows if applier configured to skip conflicting > rows. This enforces wal consistency. The patch may be worthwhile, but the comment sounds very obscure. What's "wal consistency"? How can the wal become inconsistent without this patch? Shouldn't there be a test proving this patch is correct? > > Prerequisite #980 > --- > src/box/applier.cc | 29 ++++++++++++++++------------- > 1 file changed, 16 insertions(+), 13 deletions(-) > > diff --git a/src/box/applier.cc b/src/box/applier.cc > index 148c8ce5a..adbe88679 100644 > --- a/src/box/applier.cc > +++ b/src/box/applier.cc > @@ -533,23 +533,26 @@ applier_subscribe(struct applier *applier) > row.replica_id); > vclock_follow_xrow(&replicaset.applier.vclock, &row); > int res = xstream_write(applier->subscribe_stream, &row); > - if (res != 0) { > - struct error *e = diag_last_error(diag_get()); > + struct error *e = diag_last_error(diag_get()); > + if (res != 0 && e->type == &type_ClientError && > + box_error_code(e) == ER_TUPLE_FOUND && > + replication_skip_conflict) { > /** > * Silently skip ER_TUPLE_FOUND error if such > * option is set in config. > */ > - if (e->type == &type_ClientError && > - box_error_code(e) == ER_TUPLE_FOUND && > - replication_skip_conflict) > - diag_clear(diag_get()); > - else { > - /* Rollback lsn to have a chance for a retry. */ > - vclock_set(&replicaset.applier.vclock, > - row.replica_id, old_lsn); > - latch_unlock(latch); > - diag_raise(); > - } > + diag_clear(diag_get()); > + row.type = IPROTO_NOP; > + row.bodycnt = 0; > + res = xstream_write(applier->subscribe_stream, > + &row); A comment explaining why this is done would be nice to have. > + } > + if (res != 0) { > + /* Rollback lsn to have a chance for a retry. */ > + vclock_set(&replicaset.applier.vclock, > + row.replica_id, old_lsn); > + latch_unlock(latch); > + diag_raise(); > } > } > done:
next prev parent reply other threads:[~2019-01-28 12:15 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-22 10:31 [tarantool-patches] [PATCH v2 0/5] Strong sequentially LSN in journal Georgy Kirichenko 2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 1/5] Do not promote wal vclock for failed writes Georgy Kirichenko 2019-01-28 11:20 ` Vladimir Davydov 2019-01-29 10:22 ` Георгий Кириченко 2019-01-29 11:58 ` Vladimir Davydov 2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 2/5] Update replicaset vclock from wal Georgy Kirichenko 2019-01-28 11:59 ` Vladimir Davydov 2019-01-29 10:33 ` [tarantool-patches] " Георгий Кириченко 2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 3/5] Enforce applier out of order protection Georgy Kirichenko 2019-01-28 12:09 ` Vladimir Davydov 2019-01-29 10:30 ` [tarantool-patches] " Георгий Кириченко 2019-01-29 12:00 ` Vladimir Davydov 2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 4/5] Emit NOP if an applier skips row Georgy Kirichenko 2019-01-28 12:15 ` Vladimir Davydov [this message] 2019-02-08 16:50 ` [tarantool-patches] " Konstantin Osipov 2019-01-22 10:31 ` [tarantool-patches] [PATCH v2 5/5] Disallow lsn gaps while vclock following Georgy Kirichenko 2019-01-28 12:18 ` Vladimir Davydov 2019-01-28 11:15 ` [tarantool-patches] [PATCH v2 0/5] Strong sequentially LSN in journal Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190128121540.gppxu7f544wgpi67@esperanza \ --to=vdavydov.dev@gmail.com \ --cc=georgy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v2 4/5] Emit NOP if an applier skips row' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox