From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces
Date: Thu, 24 Jan 2019 20:26:31 +0300 [thread overview]
Message-ID: <20190124172631.ja77fzab2m2rerco@esperanza> (raw)
In-Reply-To: <b9fda4a9ce89b2f2773a648127e26e808ff40821.1548333874.git.kyukhin@tarantool.org>
On Thu, Jan 24, 2019 at 03:48:46PM +0300, Kirill Yukhin wrote:
> Before the patch, when ephemeral space was created flag
> is_temporary was set after space was actually created.
> Which in turn lead to corresponding flag of tuple_format
> being set to `false`.
> So, having heavy load using ephemeral spaces (almost any
> SQL query) and snapshotting at the same time might lead
> to OOM, since tuples of ephemeral spaces were not marked
> as temporary and were not gc-ed.
> Patch sets the flag in space definition.
> ---
> src/box/space.c | 2 +-
> src/box/space_def.c | 14 ++++++++++++++
> src/box/space_def.h | 9 +++++++++
> src/box/sql.c | 6 +-----
> 4 files changed, 25 insertions(+), 6 deletions(-)
Pushed to 2.1
next prev parent reply other threads:[~2019-01-24 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 12:48 [PATCH v2 0/4] Reuse tuple formats for " Kirill Yukhin
2019-01-24 12:48 ` [PATCH v2 1/4] Pass necessary fields to tuple_format contructor Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov
2019-01-24 12:48 ` [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov [this message]
2019-01-24 12:48 ` [PATCH v2 3/4] sql: set error type in case of ephemral space creation failure Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov
2019-01-24 12:48 ` [PATCH v2 4/4] Allow to reuse tuple_formats for ephemeral spaces Kirill Yukhin
2019-01-24 17:49 ` Vladimir Davydov
2019-01-25 6:05 ` Kirill Yukhin
2019-01-25 9:01 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124172631.ja77fzab2m2rerco@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox