From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH v2 1/4] Pass necessary fields to tuple_format contructor
Date: Thu, 24 Jan 2019 20:26:21 +0300 [thread overview]
Message-ID: <20190124172621.agcjkr5bcbm5srzt@esperanza> (raw)
In-Reply-To: <8b7dbf2828cbab2ed7e11406dbd3b5e503a50493.1548333874.git.kyukhin@tarantool.org>
On Thu, Jan 24, 2019 at 03:48:45PM +0300, Kirill Yukhin wrote:
> There were three extra fields of tuple_format which were setup
> after it was created. Fix that by extending tuple_format
> contstructor w/ three new arguments: engine, is_temporary,
> exact_field_count.
> ---
> src/box/blackhole.c | 6 +++---
> src/box/memtx_space.c | 9 ++++-----
> src/box/tuple.c | 8 ++++----
> src/box/tuple_format.c | 13 ++++++++-----
> src/box/tuple_format.h | 11 ++++++++---
> src/box/vinyl.c | 11 ++++++-----
> src/box/vy_lsm.c | 9 +++++----
> test/unit/vy_iterators_helper.c | 12 ++++++------
> test/unit/vy_mem.c | 4 ++--
> test/unit/vy_point_lookup.c | 4 ++--
> 10 files changed, 48 insertions(+), 39 deletions(-)
Pushed to 2.1
next prev parent reply other threads:[~2019-01-24 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 12:48 [PATCH v2 0/4] Reuse tuple formats for ephemeral spaces Kirill Yukhin
2019-01-24 12:48 ` [PATCH v2 1/4] Pass necessary fields to tuple_format contructor Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov [this message]
2019-01-24 12:48 ` [PATCH v2 2/4] Set is_temporary flag for formats of ephemeral spaces Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov
2019-01-24 12:48 ` [PATCH v2 3/4] sql: set error type in case of ephemral space creation failure Kirill Yukhin
2019-01-24 17:26 ` Vladimir Davydov
2019-01-24 12:48 ` [PATCH v2 4/4] Allow to reuse tuple_formats for ephemeral spaces Kirill Yukhin
2019-01-24 17:49 ` Vladimir Davydov
2019-01-25 6:05 ` Kirill Yukhin
2019-01-25 9:01 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190124172621.agcjkr5bcbm5srzt@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [PATCH v2 1/4] Pass necessary fields to tuple_format contructor' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox