Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: make IN operator stop ignoring type and collation
Date: Thu, 24 Jan 2019 16:56:21 +0300	[thread overview]
Message-ID: <20190124135620.ubtuykuusq25ezmz@tarantool.org> (raw)
In-Reply-To: <20190116133401.5844-1-korablev@tarantool.org>

Hello,

On 16 Jan 16:34, Nikita Pettik wrote:
> SQLite discards type and collation of IN operator when it comes with
> only one operand. This leads to different results of straight comparison
> using '=' operator and IN:
> 
> SELECT x FROM t1 WHERE x IN (1.0);
> -- Result is empty set
> SELECT x FROM t1 WHERE x = 1.0;
> - - ['1']
> 
> Lets remove this strange ignorance and always take into consideration
> types and collations of operands.
> 
> Closes #3934
> ---
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3934-IN-operator-fix
> Issue: https://github.com/tarantool/tarantool/issues/3934

I've checked your patch into 2.1 branch.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2019-01-24 13:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 13:34 [tarantool-patches] " Nikita Pettik
2019-01-17 19:53 ` [tarantool-patches] " Vladislav Shpilevoy
2019-01-24 13:56 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190124135620.ubtuykuusq25ezmz@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH] sql: make IN operator stop ignoring type and collation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox