Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Alex Khatskevich <avkhatskevich@tarantool.org>
Cc: kyukhin@tarantool.org, tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 2/2] lua-yaml: fix yaml encode/decode type inferring
Date: Tue, 22 Jan 2019 05:08:45 +0300	[thread overview]
Message-ID: <20190122020845.kxzknrjvi5jikhb3@tkn_work_nb> (raw)
In-Reply-To: <9fab4f4496d3c255ed1de3c7642817d07992a7af.1538663611.git.avkhatskevich@tarantool.org>

Changes I made:

* Moved str_type.h to lyaml.cc.
* Simplified cases in app-tap/console.test.lua, added more.
* Extracted an empty document / value treatment change into a separate
  commit.
* Removed hacking around console.eval() result in
  test/vinyl/txn_proxy.lua.
* Rebased at top of 2.1.
* Better describe changes in commit messages.

I'll push the patchset to kh/gh-3662-yaml-2.1 and will resend it as v2.

WBR, Alexander Turenko.

On Thu, Oct 04, 2018 at 05:36:14PM +0300, AKhatskevich wrote:
> Changes:
> * encode boolean values in single-quoted style
> * encode/decode nulls as '', '~', 'null', 'Null', "NULL", according
>   to the yaml 1.0/1.1/1.2 standard
> * fix affected tests
> 
> Related to #3476
> Closes #3662 #3583
> ---
>  test/app-tap/console.test.lua   |   25 +-
>  test/app/fio.result             |    2 +-
>  test/app/socket.result          |   26 +-
>  test/box/access.result          |    8 +-
>  test/box/misc.result            |    2 +-
>  test/box/role.result            |    8 +-
>  test/box/sequence.result        |    2 +-
>  test/vinyl/errinj.result        |   10 +-
>  test/vinyl/hermitage.result     |  122 ++---
>  test/vinyl/mvcc.result          | 1062 +++++++++++++++++++--------------------
>  test/vinyl/tx_conflict.result   |    4 +-
>  test/vinyl/tx_conflict.test.lua |    4 +-
>  test/vinyl/tx_gap_lock.result   |  186 +++----
>  test/vinyl/tx_serial.result     |    4 +-
>  test/vinyl/tx_serial.test.lua   |    4 +-
>  test/vinyl/txn_proxy.lua        |    6 +
>  third_party/lua-yaml/lyaml.cc   |   43 +-
>  third_party/lua-yaml/str_type.h |   33 ++
>  18 files changed, 802 insertions(+), 749 deletions(-)
>  create mode 100644 third_party/lua-yaml/str_type.h

      reply	other threads:[~2019-01-22  2:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 14:36 [tarantool-patches] [PATCH 0/2] fix yaml encode/decode AKhatskevich
2018-10-04 14:36 ` [tarantool-patches] [PATCH 1/2] lua-yaml: fix read garbage bug AKhatskevich
2018-10-04 14:36 ` [tarantool-patches] [PATCH 2/2] lua-yaml: fix yaml encode/decode type inferring AKhatskevich
2019-01-22  2:08   ` Alexander Turenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122020845.kxzknrjvi5jikhb3@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=avkhatskevich@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] lua-yaml: fix yaml encode/decode type inferring' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox