From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: korablev@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast
Date: Fri, 18 Jan 2019 21:00:52 +0300 [thread overview]
Message-ID: <20190118180052.GA24439@chai> (raw)
In-Reply-To: <347e0f9e4c81bf76520c167a00f7af661b76aa64.1547128310.git.kshcherbatov@tarantool.org>
* Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/01/10 23:12]:
> The checks field of space_opts object renamed to checks_ast to avoid a
> confusion due to introduction of a new object sql_check, representing
> precompiled VDBE program to execute.
Please use name check_constraint_expr
A common abbreviation for foreign key constraint is fk, check
constarint - ck, not null - nn, so an alternative family of names
would be fk_constraint, ck_constraint, nn_constraint. Feel free to
use it if you like a bit shorter form.
> + if (def->opts.checks_ast != NULL &&
> + sql_checks_resolve_space_def_reference(def->opts.checks_ast,
Please name the module 'check_constraint' or ck_constraint, and rename all the
functions accordingly.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-01-18 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 13:54 [tarantool-patches] [PATCH v1 0/4] sql: Checks on server side Kirill Shcherbatov
2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 1/4] box: rename space->opts checks to checks_ast Kirill Shcherbatov
2019-01-11 14:05 ` [tarantool-patches] " Konstantin Osipov
2019-01-18 18:00 ` Konstantin Osipov [this message]
2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 2/4] sql: disallow use of TYPEOF in Check Kirill Shcherbatov
2019-01-11 14:06 ` [tarantool-patches] " Konstantin Osipov
2019-01-11 14:07 ` Konstantin Osipov
2019-01-18 18:04 ` Konstantin Osipov
2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 3/4] box: exported sql_bind structure and API Kirill Shcherbatov
2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 4/4] sql: make sql checks on server side Kirill Shcherbatov
2019-01-11 14:12 ` [tarantool-patches] " Konstantin Osipov
2019-01-11 14:14 ` Konstantin Osipov
2019-01-18 18:11 ` Konstantin Osipov
2019-01-21 14:47 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118180052.GA24439@chai \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox