From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: vdavydov.dev@gmail.com, kostja@tarantool.org,
tarantool-patches@freelists.org,
Kirill Shcherbatov <kshcherbatov@gmail.com>
Subject: Re: [tarantool-patches] [PATCH v1 1/1] implement mp_stack class
Date: Thu, 17 Jan 2019 14:58:43 +0300 [thread overview]
Message-ID: <20190117115843.nqellm5mmsglqnlf@tkn_work_nb> (raw)
In-Reply-To: <9613f79e65d9838763422aae0bfb3ca9e2901a32.1547645639.git.kshcherbatov@gmail.com>
Look at the `make doc` warnings, the doxygen format is slightly
different then yours one.
Please, start the commit mesaage from the upper letter (because it has
no prefix).
Can you please share how do you intend to use it? One or more real
cases.
WBR, Alexander Turenko.
On Wed, Jan 16, 2019 at 04:36:12PM +0300, Kirill Shcherbatov wrote:
> From: Kirill Shcherbatov <kshcherbatov@gmail.com>
>
> https://github.com/tarantool/tarantool/tree/kshch/gh-1012-msgpuck-class
It is tarantool/small, not tarantool/tarantool.
> +/**
> + * \brief Advance a mp_stack::curr attribute of the mp_stack.
> + * \stack top frame. The \stack must not be empty.
> + * \retval true, when the top frame have already parsed:
> + * mp_stack::curr >= mp_stack::size; false otherwise.
mp_stack::curr -> mp_stack_top()::curr
mp_stack::size -> mp_stack_top()::size
next prev parent reply other threads:[~2019-01-17 11:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 13:36 Kirill Shcherbatov
2019-01-16 18:03 ` Konstantin Osipov
2019-01-17 7:26 ` Kirill Shcherbatov
2019-01-17 7:32 ` [tarantool-patches] " Kirill Shcherbatov
2019-01-17 11:58 ` Alexander Turenko [this message]
2019-01-17 12:28 ` [tarantool-patches] " Kirill Shcherbatov
2019-01-17 16:34 ` Alexander Turenko
2019-01-18 7:03 ` Kirill Shcherbatov
2019-01-18 10:32 ` Kirill Shcherbatov
2019-01-21 9:46 ` Kirill Shcherbatov
2019-01-21 11:25 ` Alexander Turenko
2019-01-21 12:35 ` Kirill Shcherbatov
2019-01-21 20:25 ` Vladimir Davydov
2019-01-22 12:28 ` Kirill Shcherbatov
2019-01-22 20:21 ` Vladimir Davydov
2019-01-23 8:23 ` Kirill Shcherbatov
2019-01-23 10:06 ` Vladimir Davydov
2019-01-23 11:39 ` Kirill Shcherbatov
2019-01-24 17:58 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117115843.nqellm5mmsglqnlf@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=kostja@tarantool.org \
--cc=kshcherbatov@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] [PATCH v1 1/1] implement mp_stack class' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox