Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH 00/12] vinyl: statistics improvements
Date: Thu, 17 Jan 2019 14:32:36 +0300	[thread overview]
Message-ID: <20190117113236.GD28204@chai> (raw)
In-Reply-To: <cover.1547558871.git.vdavydov.dev@gmail.com>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/01/15 17:20]:
> This patch set adds a few metrics necessary for implementing compaction
> randomization and transaction throttling, but it's useful on its own,
> because it makes box.stat.vinyl() a little bit more useful when it comes
> to performance analysis. Here's an example of box.stat.vinyl() output
> with this patch set applied:

Please write a documentation request which explains the meaning of
these variables. AFAIK these stats are still not described in the
manual. Please try to explain why these statistics are useful, and
how they can be used.

> ---
> - tx:
>     conflict: 0
>     commit: 1979052
>     rollback: 0
>     statements: 2
>     transactions: 1
>     gap_locks: 0
>     read_views: 0
>   regulator:

let's rename it to rate_limit or rate_limits? Regulator is not
specific enough. What does it regulate?

>     dump_bandwidth: 10485760
Without comments even I forget the meaning of these.

>     dump_watermark: 20023725
>     write_rate: 7085581

>   memory:
>     tuple_cache: 0
>     tx: 2388
>     level0: 19394239
>     page_index: 4422529
>     bloom_filter: 1517177

Good.

>   disk:
>     data_compacted: 500330587

What's this? 

>     data: 762493299
>     index: 41814873
>   scheduler:
>     dump_time: 186.61679973663

It's total dump time, the name can be confused with
last dump time.

>     tasks_inprogress: 3
>     dump_output: 2115930554
>     compaction_queue: 213022513
>     compaction_output: 4130054964
>     compaction_time: 737.99443827965
>     dump_count: 136
>     tasks_failed: 0
>     tasks_completed: 1839
>     dump_input: 2061676471
>     compaction_input: 5646476938

-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

  parent reply	other threads:[~2019-01-17 11:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 14:17 Vladimir Davydov
2019-01-15 14:17 ` [PATCH 01/12] test: rename vinyl/info to vinyl/stat Vladimir Davydov
2019-01-17 11:32   ` [tarantool-patches] " Konstantin Osipov
2019-01-15 14:17 ` [PATCH 02/12] test: split vinyl/errinj Vladimir Davydov
2019-01-17 11:33   ` [tarantool-patches] " Konstantin Osipov
2019-01-15 14:17 ` [PATCH 03/12] vinyl: rename dump/compact in/out to input/output Vladimir Davydov
2019-01-17 11:33   ` [tarantool-patches] " Konstantin Osipov
2019-01-15 14:17 ` [PATCH 04/12] vinyl: rename compact to compaction Vladimir Davydov
2019-01-17 11:34   ` [tarantool-patches] " Konstantin Osipov
2019-01-17 12:08     ` Vladimir Davydov
2019-01-17 13:51       ` Konstantin Osipov
2019-01-15 14:17 ` [PATCH 05/12] vinyl: bump range version in vy_range.c Vladimir Davydov
2019-01-15 14:17 ` [PATCH 06/12] vinyl: don't add dropped LSM trees to the scheduler during recovery Vladimir Davydov
2019-01-15 14:17 ` [PATCH 07/12] vinyl: move global dump/compaction statistics to scheduler Vladimir Davydov
2019-01-16 16:36   ` Vladimir Davydov
2019-01-15 14:17 ` [PATCH 08/12] vinyl: add dump count to global scheduler statistics Vladimir Davydov
2019-01-15 14:17 ` [PATCH 09/12] vinyl: don't account secondary indexes to scheduler.dump_input Vladimir Davydov
2019-01-15 14:17 ` [PATCH 10/12] vinyl: add task accounting to global scheduler statistics Vladimir Davydov
2019-01-15 14:17 ` [PATCH 11/12] vinyl: add dump/compaction time to statistics Vladimir Davydov
2019-01-15 14:17 ` [PATCH 12/12] vinyl: add last level size " Vladimir Davydov
2019-01-17 11:35   ` [tarantool-patches] " Konstantin Osipov
2019-01-17 11:32 ` Konstantin Osipov [this message]
2019-01-17 12:06   ` [tarantool-patches] Re: [PATCH 00/12] vinyl: statistics improvements Vladimir Davydov
2019-01-20 21:16 ` Vladimir Davydov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117113236.GD28204@chai \
    --to=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 00/12] vinyl: statistics improvements' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox