From: Konstantin Osipov <kostja@tarantool.org> To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast Date: Fri, 11 Jan 2019 17:05:35 +0300 [thread overview] Message-ID: <20190111140535.GA31711@chai> (raw) In-Reply-To: <347e0f9e4c81bf76520c167a00f7af661b76aa64.1547128310.git.kshcherbatov@tarantool.org> * Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/01/10 23:12]: > + /** Checks AST expressions list. */ > + struct ExprList *checks_ast; I don't understand the comment. Is it a list of syntax trees or a syntax tree containing all checks? You can't use plural in an adjective. This is a systematic error which I have been pointing out before. > --- a/src/box/sql.c > +++ b/src/box/sql.c > @@ -1048,7 +1048,7 @@ sql_encode_table_opts(struct region *region, struct Table *table, > int checks_cnt = 0; > struct ExprList_item *a; > bool is_view = table->def->opts.is_view; > - struct ExprList *checks = table->def->opts.checks; > + struct ExprList *checks = table->def->opts.checks_ast; It's good manners to consistently rename stack variables when renaming the corresponding member. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-01-11 14:05 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-10 13:54 [tarantool-patches] [PATCH v1 0/4] sql: Checks on server side Kirill Shcherbatov 2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 1/4] box: rename space->opts checks to checks_ast Kirill Shcherbatov 2019-01-11 14:05 ` Konstantin Osipov [this message] 2019-01-18 18:00 ` [tarantool-patches] " Konstantin Osipov 2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 2/4] sql: disallow use of TYPEOF in Check Kirill Shcherbatov 2019-01-11 14:06 ` [tarantool-patches] " Konstantin Osipov 2019-01-11 14:07 ` Konstantin Osipov 2019-01-18 18:04 ` Konstantin Osipov 2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 3/4] box: exported sql_bind structure and API Kirill Shcherbatov 2019-01-10 13:54 ` [tarantool-patches] [PATCH v1 4/4] sql: make sql checks on server side Kirill Shcherbatov 2019-01-11 14:12 ` [tarantool-patches] " Konstantin Osipov 2019-01-11 14:14 ` Konstantin Osipov 2019-01-18 18:11 ` Konstantin Osipov 2019-01-21 14:47 ` n.pettik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190111140535.GA31711@chai \ --to=kostja@tarantool.org \ --cc=korablev@tarantool.org \ --cc=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v1 1/4] box: rename space->opts checks to checks_ast' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox