Tarantool development patches archive
 help / color / mirror / Atom feed
From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Serge Petrenko <sergepetrenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v4 2/2] box: implement on_shutdown triggers
Date: Wed, 9 Jan 2019 17:01:08 +0300	[thread overview]
Message-ID: <20190109140108.GH20509@chai> (raw)
In-Reply-To: <20190109101449.2325eebtrj7xsdlr@esperanza>

* Vladimir Davydov <vdavydov.dev@gmail.com> [19/01/09 13:16]:
> > +/** Invoked on box shutdown. */
> > +extern struct rlist box_on_shutdown;
> > +
> 
> Nit: it would be nice to say here that it is only invoked upon receiving
> a terminating signal, not when os.exit() is called.

This is a usability problem. We need to monkey-patch os.exit() to
call these triggers. Sergey, please do it in a separate patch.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov

      reply	other threads:[~2019-01-09 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29 13:45 [PATCH v4 0/2] " Serge Petrenko
2018-12-29 13:45 ` [PATCH v4 1/2] box: get rid of atexit() for calling cleanup routines Serge Petrenko
2018-12-29 13:45 ` [PATCH v4 2/2] box: implement on_shutdown triggers Serge Petrenko
2019-01-09 10:14   ` Vladimir Davydov
2019-01-09 14:01     ` Konstantin Osipov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109140108.GH20509@chai \
    --to=kostja@tarantool.org \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v4 2/2] box: implement on_shutdown triggers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox