From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: fix lemon memory leak reported by ASAN
Date: Wed, 9 Jan 2019 11:57:33 +0300 [thread overview]
Message-ID: <20190109085733.2gq2c6ru6wrxahav@tkn_work_nb> (raw)
In-Reply-To: <20190109072015.gruplrs6gyrcu66w@tarantool.org>
On Wed, Jan 09, 2019 at 10:20:15AM +0300, Kirill Yukhin wrote:
> Hello,
> On 05 Jan 16:13, Alexander Turenko wrote:
> > It catched by ASAN at build time (lemon is executed to generate
> > parse.[ch]), so tarantool couldn't be built with -DENABLE_ASAN=ON.
> > ---
> >
> > no issue
> > https://github.com/tarantool/tarantool/tree/Totktonada/fix-lemon-memleak
> I've pushed your patch into 2.1 branch.
>
> Should we propose a patch to SQLite?
It is not so important unless you are using ASAN and I think in SQLite
it only run in the maintainer mode.
SQLite requires to sign-off dedication document before contribute. The
patch I think is not enough reason to do that.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2019-01-09 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 13:13 [tarantool-patches] " Alexander Turenko
2019-01-09 7:20 ` [tarantool-patches] " Kirill Yukhin
2019-01-09 8:57 ` Alexander Turenko [this message]
2019-01-09 11:39 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109085733.2gq2c6ru6wrxahav@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: fix lemon memory leak reported by ASAN' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox