From: Vladimir Davydov <vdavydov.dev@gmail.com>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH v1 4/4] box: refactor tuple_init_field_map to use bitmap
Date: Sat, 29 Dec 2018 16:22:14 +0300 [thread overview]
Message-ID: <20181229132213.w7qpudy45tpye7p5@esperanza> (raw)
In-Reply-To: <a29b2265-a793-e12f-cee5-f3d2fdb5f978@tarantool.org>
On Sat, Dec 29, 2018 at 03:58:34PM +0300, Kirill Shcherbatov wrote:
> > field_count can't be 0 - otherwise we would bail out early.
> It is not so, try paste assert here and run
>
> s = box.schema.space.create('test', {engine = engine})
> pk = s:create_index('pk')
> sk = s:create_index('sk', {parts = {{2, 'unsigned', is_nullable = true}}})
> s:replace{} -- Fail
OK, I confused tuple field count with format field count.
next prev parent reply other threads:[~2018-12-29 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 11:15 [PATCH v1 0/4] box: JSON preparatory patchset Kirill Shcherbatov
2018-12-27 11:15 ` [PATCH v1 1/4] lib: introduce json_tree_snprint_path Kirill Shcherbatov
2018-12-27 18:51 ` Vladimir Davydov
2018-12-27 11:15 ` [PATCH v1 2/4] lib: introduce json_token_is_leaf helper Kirill Shcherbatov
2018-12-27 18:52 ` Vladimir Davydov
2018-12-27 11:15 ` [PATCH v1 3/4] box: introduce bitmap_majority_test routine Kirill Shcherbatov
2018-12-27 18:59 ` Vladimir Davydov
2018-12-29 12:58 ` [tarantool-patches] " Kirill Shcherbatov
2018-12-29 13:19 ` Vladimir Davydov
2018-12-29 13:57 ` Kirill Shcherbatov
2018-12-29 16:16 ` Vladimir Davydov
2018-12-27 11:15 ` [PATCH v1 4/4] box: refactor tuple_init_field_map to use bitmap Kirill Shcherbatov
2018-12-27 11:48 ` [tarantool-patches] " Konstantin Osipov
2018-12-27 19:12 ` Vladimir Davydov
2018-12-29 12:58 ` [tarantool-patches] " Kirill Shcherbatov
2018-12-29 13:22 ` Vladimir Davydov [this message]
2018-12-29 16:25 ` Vladimir Davydov
2018-12-27 19:13 ` [PATCH v1 0/4] box: JSON preparatory patchset Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229132213.w7qpudy45tpye7p5@esperanza \
--to=vdavydov.dev@gmail.com \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] Re: [PATCH v1 4/4] box: refactor tuple_init_field_map to use bitmap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox