From: Konstantin Osipov <kostja@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [tarantool-patches] Re: [PATCH 1/5] recovery: stop writing to xstream on system error
Date: Sat, 29 Dec 2018 15:08:49 +0300 [thread overview]
Message-ID: <20181229120849.GF17043@chai> (raw)
In-Reply-To: <20181229105704.4oy2gn7hiyni5xvo@esperanza>
* Vladimir Davydov <vdavydov.dev@gmail.com> [18/12/29 15:07]:
> On Sat, Dec 29, 2018 at 12:50:52PM +0300, Vladimir Davydov wrote:
> > On Sat, Dec 29, 2018 at 12:09:09PM +0300, Konstantin Osipov wrote:
> > > * Vladimir Davydov <vdavydov.dev@gmail.com> [18/12/29 10:00]:
> > >
> > > force_recovery as an option should only affect local recovery, not
> > > relays. Why is it set for relay xlog?
> >
> > For the record. Discussed f2f and agreed that it seems weird to set
> > force_recovery for relay threads, however, changing this behavior now
> > may break existing customers. So we should push this patch as is to
> > 1.10, but for 2.1 do not set force_recovery flag instead.
>
> Here's the alternative fix that will go to 2.1:
Thanks.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2018-12-29 12:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 21:21 [PATCH 0/5] Fix a couple of replication breakdown issues Vladimir Davydov
2018-12-28 21:21 ` [PATCH 1/5] recovery: stop writing to xstream on system error Vladimir Davydov
2018-12-29 9:09 ` [tarantool-patches] " Konstantin Osipov
2018-12-29 9:50 ` Vladimir Davydov
2018-12-29 10:57 ` Vladimir Davydov
2018-12-29 12:08 ` Konstantin Osipov [this message]
2018-12-28 21:21 ` [PATCH 2/5] relay: do not try to scan xlog if exiting Vladimir Davydov
2018-12-29 9:14 ` [tarantool-patches] " Konstantin Osipov
2018-12-29 9:53 ` Vladimir Davydov
2018-12-28 21:21 ` [PATCH 3/5] relay: cleanup error handling Vladimir Davydov
2018-12-28 21:21 ` [PATCH 4/5] relay: close xlog cursor in relay thread Vladimir Davydov
2018-12-28 21:21 ` [PATCH 5/5] xlog: assure xlog is opened and closed in the same thread Vladimir Davydov
2018-12-29 11:40 ` [PATCH 0/5] Fix a couple of replication breakdown issues Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181229120849.GF17043@chai \
--to=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH 1/5] recovery: stop writing to xstream on system error' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox